Skip to content

perf: Speed up compilation by reducing redundant type normalization #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2024
Merged

perf: Speed up compilation by reducing redundant type normalization #896

merged 2 commits into from
Aug 9, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 9, 2024
@TrevorBergeron TrevorBergeron marked this pull request as ready for review August 9, 2024 20:42
@TrevorBergeron TrevorBergeron requested review from a team as code owners August 9, 2024 20:42
@TrevorBergeron TrevorBergeron requested a review from tswast August 9, 2024 20:42
tswast
tswast approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all tests pass

@TrevorBergeron TrevorBergeron merged commit e0b11bc into main Aug 9, 2024
23 checks passed
@TrevorBergeron TrevorBergeron deleted the compile_fast branch August 9, 2024 23:00
@release-please release-please bot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@junyazhang junyazhang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @tswast @junyazhang