Skip to content

docs: add columns for "requires ordering/index" to supported APIs summary #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners August 8, 2024 16:30
@tswast tswast requested a review from Genesis929 August 8, 2024 16:30
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 8, 2024
@tswast tswast changed the title docs: add columns for "requires ordering/index" to supported APIs sum… docs: add columns for "requires ordering/index" to supported APIs summary Aug 8, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Aug 8, 2024
@TrevorBergeron
Copy link
Contributor

There are a few APIs for which order- or index-dependence is conditional on the parameters passed. Presently, these apis have conditional statements inside the body instead of using the decorator. One such case is drop_duplicates. Not sure how we would want to label these APIs in the docs.

@Genesis929 Genesis929 merged commit d2fc51a into main Aug 20, 2024
23 checks passed
@Genesis929 Genesis929 deleted the tswast-docs-requires_ordering branch August 20, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants