Skip to content

feat: add ml.preprocessing.KBinsDiscretizer #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 4, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners October 2, 2023 23:12
@ashleyxuu ashleyxuu requested a review from milkshakeiii October 2, 2023 23:12
@ashleyxuu ashleyxuu self-assigned this Oct 2, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 2, 2023
@ashleyxuu ashleyxuu requested a review from GarrettWu October 2, 2023 23:14
s = sql[sql.find("(") + 1 : sql.find(")")]
array_split_points = s[s.find("[") + 1 : s.find("]")]
col_label = s[: s.find(",")]
n_bins = array_split_points.count(",") + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-kbins-discretizer branch from 4efcd9c to fbab743 Compare October 3, 2023 18:22
@ashleyxuu ashleyxuu merged commit 24c6256 into main Oct 4, 2023
@ashleyxuu ashleyxuu deleted the ashleyxu-add-kbins-discretizer branch October 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants