Skip to content

feat: add bigframes.bigquery.json_set #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 29, 2024
Merged

feat: add bigframes.bigquery.json_set #782

merged 7 commits into from
Jun 29, 2024

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Jun 12, 2024 •
edited by tswast
Loading

BEGIN_COMMIT_OVERRIDE
feat: add bigframes.bigquery.json_set (#782)
END_COMMIT_OVERRIDE

This change is creating a bigframes.bigquery.json_set API, which can produces a new JSON value within a Series by inserting or replacing values at specified paths.

  • Make sure to open an issue as a internal bug 346813016
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 346813016 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 12, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_json_set branch from f4a8c4e to bcc39b6 Compare June 12, 2024 22:49
@chelsea-lin chelsea-lin marked this pull request as ready for review June 12, 2024 22:50
@chelsea-lin chelsea-lin requested review from a team as code owners June 12, 2024 22:50
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_json_set branch from d5ca55b to 647ea5e Compare June 27, 2024 18:04
TrevorBergeron
TrevorBergeron reviewed Jun 27, 2024
View reviewed changes
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_json_set branch from 647ea5e to fdb9c40 Compare June 28, 2024 21:29
TrevorBergeron
TrevorBergeron approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelsea-lin chelsea-lin merged commit 1b613e0 into main Jun 29, 2024
23 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_json_set branch June 29, 2024 04:49
@release-please release-please bot mentioned this pull request Jun 29, 2024
Merged
@tswast tswast changed the title feat: bigframes.bigquery.json_set feat: add bigframes.bigquery.json_set Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@junyazhang junyazhang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chelsea-lin @tswast @TrevorBergeron @junyazhang