Skip to content

fix: avoid 403 response too large to return error with read_gbq and large query results #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 3, 2023
Merged

fix: avoid 403 response too large to return error with read_gbq and large query results #77

merged 13 commits into from
Oct 3, 2023

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 2, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 303057336 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 2, 2023
@tswast tswast marked this pull request as ready for review October 3, 2023 16:13
@tswast tswast requested review from a team as code owners October 3, 2023 16:13
@tswast tswast requested review from liujiashang and GarrettWu and removed request for liujiashang October 3, 2023 16:13
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 3, 2023
GarrettWu
GarrettWu approved these changes Oct 3, 2023
View reviewed changes
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8f3b5b2 into main Oct 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the b303057336-403-too-large branch October 3, 2023 20:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@release-please release-please bot mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @GarrettWu