Skip to content

feat: add multi-column dataframe merge #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

feat: add multi-column dataframe merge #73

merged 2 commits into from
Oct 3, 2023

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners September 29, 2023 22:02
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 29, 2023
milkshakeiii
milkshakeiii approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@milkshakeiii milkshakeiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will help with dropping by index

@TrevorBergeron TrevorBergeron merged commit c9fa85c into main Oct 3, 2023
@TrevorBergeron TrevorBergeron deleted the multimerge branch October 3, 2023 07:59
@release-please release-please bot mentioned this pull request Oct 3, 2023
Merged
ashleyxuu pushed a commit that referenced this pull request Oct 3, 2023
@TrevorBergeron @ashleyxuu
feat: add multi-column dataframe merge (#73)
eb5ca0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milkshakeiii milkshakeiii milkshakeiii approved these changes

@shobsi shobsi Awaiting requested review from shobsi shobsi is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @milkshakeiii