Skip to content

feat: allow functions returned from bpd.read_gbq_function to execute outside of apply #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 4, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 17, 2024

Tested manually:

import bigframes.pandas as bpd

func = bpd.read_gbq_function("bqutil.fn.cw_lower_case_ascii_only")
func("AURÉLIE")
# Out[3]: 'aurÉlie'

TODO

🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 17, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 24, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 25, 2024
@tswast tswast marked this pull request as ready for review May 30, 2024 14:52
@tswast tswast requested review from a team as code owners May 30, 2024 14:52
@tswast tswast requested a review from TrevorBergeron May 30, 2024 14:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 30, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 30, 2024
):
"""
Read an existing BigQuery function and prepare it for use in future queries.
"""

# A BigQuery client is required to perform BQ operations
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of system tests, there weren't any code paths that passed in bigquery_client but not session, so removing this unnecessary logic.

@tswast tswast merged commit ad7d8ac into main Jun 4, 2024
21 of 23 checks passed
@tswast tswast deleted the tswast-read_gbq_function-local-testing branch June 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants