feat: Add Series.combine #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
chelsea-lin
approved these changes
May 10, 2024
| Now, to combine the two datasets and view the highest speeds | ||
| of the birds across the two datasets | ||
|
|
||
| >>> s1.combine(s2, np.maximum) |
There was a problem hiding this comment.
The order of the outputs are different as pandas. How we decide the ordering of the output?
There was a problem hiding this comment.
Pandas will check the index of both sides, if they are not exactly the same, it will sort the index. If we wanted to copy this behavior, we would need to download the index from both sides of the operation, which I don't think is worth it. Users can always call sort_index() after combining if needed.
| other (Series or scalar): | ||
| The value(s) to be combined with the `Series`. | ||
| func (function): | ||
| BigFrames DataFrames ``remote_function`` to apply. |
There was a problem hiding this comment.
Is the np.maxinum a remote function in the example?
There was a problem hiding this comment.
Its a numpy ufunc. Having remote functions in the doctests has been problematic so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕