Skip to content

feat: Implement DataFrame.dot for matrix multiplication #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 19, 2023
Merged

feat: Implement DataFrame.dot for matrix multiplication #67

merged 11 commits into from
Oct 19, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Sep 27, 2023 •
edited
Loading

Change-Id: I8baa8c8ee0aeef587be25519a9df549e6db70067

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #b/300001052 🦕

@shobsi
feat: Implement DataFrame.dot for matrix multiplication
bf1d89f 
Change-Id: I8baa8c8ee0aeef587be25519a9df549e6db70067
@shobsi shobsi requested review from a team as code owners September 27, 2023 16:58
@shobsi shobsi requested a review from SalemJorden September 27, 2023 16:58
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 27, 2023
@tswast tswast removed the request for review from SalemJorden October 5, 2023 21:42
tswast
tswast requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Glad to see the pivot optimization that avoids running the multiplication twice.

A few comments.

@shobsi shobsi requested a review from TrevorBergeron October 7, 2023 00:28
tswast
tswast reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd like Trevor to take a look before merging. Thanks!

@tswast tswast self-requested a review October 11, 2023 21:46
@tswast tswast self-requested a review October 18, 2023 15:10
tswast
tswast requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requested changes to at least identify multiindex and raise notimplementederror as Trevor requested.

tswast
tswast requested changes Oct 18, 2023
View reviewed changes
@shobsi shobsi merged commit 29dd414 into main Oct 19, 2023
@shobsi shobsi deleted the shobs-df-dot branch October 19, 2023 06:16
@release-please release-please bot mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron left review comments

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @tswast @TrevorBergeron