-
Notifications
You must be signed in to change notification settings - Fork 48
docs: address lint errors in code samples #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Towards internal issue 332735129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The samples and lints are still failing. I assume you're still working on it?
Yeah. They pass locally, but I think I need to add some permissions to the connections, but I noticed there are way too many connections in the test project, so addressing that in GoogleCloudPlatform/python-docs-samples#11721 |
Internal change CL 631539944 to add the admin permissions necessary to use the remote functions sample code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Follow-up to #664 where samples lint is failing.
🦕