Skip to content

docs: address lint errors in code samples #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2024
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 7, 2024

Follow-up to #664 where samples lint is failing.
🦕

@tswast tswast requested review from a team as code owners May 7, 2024 15:05
@tswast tswast requested review from balajismaniam and ashleyxuu May 7, 2024 15:05
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels May 7, 2024
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The samples and lints are still failing. I assume you're still working on it?

@tswast
Copy link
Collaborator Author

tswast commented May 7, 2024

The samples and lints are still failing. I assume you're still working on it?

Yeah. They pass locally, but I think I need to add some permissions to the connections, but I noticed there are way too many connections in the test project, so addressing that in GoogleCloudPlatform/python-docs-samples#11721

@tswast
Copy link
Collaborator Author

tswast commented May 7, 2024

Internal change CL 631539944 to add the admin permissions necessary to use the remote functions sample code.

@tswast tswast requested a review from ashleyxuu May 8, 2024 15:52
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tswast tswast merged commit 4fc8964 into main May 8, 2024
21 checks passed
@tswast tswast deleted the tswast-samples-lint branch May 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants