Skip to content

fix: generate unique ids on join to avoid id collisions #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix: generate unique ids on join to avoid id collisions #65

merged 3 commits into from
Sep 28, 2023

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners September 26, 2023 23:45
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 26, 2023
milkshakeiii
milkshakeiii approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@milkshakeiii milkshakeiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

milkshakeiii
milkshakeiii reviewed Sep 27, 2023
View reviewed changes
bigframes/core/joins/single_column.py Outdated
@@ -26,6 +27,7 @@
import bigframes.constants as constants
import bigframes.core as core
import bigframes.core.guid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this import can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, with some slight changes, have now removed

@TrevorBergeron TrevorBergeron merged commit 7ab65e8 into main Sep 28, 2023
@TrevorBergeron TrevorBergeron deleted the integrity branch September 28, 2023 04:00
@release-please release-please bot mentioned this pull request Sep 28, 2023
Merged
ashleyxuu pushed a commit that referenced this pull request Sep 28, 2023
@TrevorBergeron @ashleyxuu
fix: generate unique ids on join to avoid id collisions (#65)
1370ee5 
* fix: generate unique ids on join to avoid id collisions
ashleyxuu pushed a commit that referenced this pull request Oct 4, 2023
@TrevorBergeron @ashleyxuu
fix: generate unique ids on join to avoid id collisions (#65)
c39adea 
* fix: generate unique ids on join to avoid id collisions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milkshakeiii milkshakeiii milkshakeiii approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @milkshakeiii