Skip to content

feat: add the bigframes.bigquery sub-package with a bigframes.bigquery.array_length function #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@chelsea-lin chelsea-lin requested a review from ashleyxuu April 22, 2024 18:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 22, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_arrayagg branch 3 times, most recently from e61ddcd to 20587eb Compare April 22, 2024 20:58
@chelsea-lin chelsea-lin marked this pull request as ready for review April 22, 2024 20:59
@chelsea-lin chelsea-lin requested review from a team as code owners April 22, 2024 20:59
@@ -189,5 +189,7 @@
uid: bigframes.ml.remote.VertexAIModel
name: remote
name: bigframes.ml
- name: Bigquery Built-in Functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the structure is wrong here? It should be parallel with bigframes.ml, bigframes.pandas and start with - items, and we want to name it bigframes.bigquery or Bigquery Built-in Functions?

You can run nox -s docfx to see if it can generate the page for you:

https://g3doc.corp.google.com/devrel/cloud/infra/devrel_services/g3doc/dev/content_automation/cloud_rad/python.md?cl=head#staging-local-changes-from-github-to-devsite to stage docs manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GarrettWu GarrettWu removed their assignment Apr 23, 2024
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets fix the spelling in the PR title as well

@tswast tswast changed the title feat: creats bigquery namespace and adds bigquery.array_length function feat: creates bigframes.bigquery sub-package and adds bigframes.bigquery.array_length function Apr 24, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_arrayagg branch from 0872885 to 5a2c2e8 Compare April 29, 2024 21:33
@tswast tswast changed the title feat: creates bigframes.bigquery sub-package and adds bigframes.bigquery.array_length function feat: add the bigframes.bigquery sub-package with a bigframes.bigquery.array_length function Apr 30, 2024
@tswast
Copy link
Collaborator

tswast commented Apr 30, 2024

e2e failure: FAILED tests/system/small/ml/test_llm.py::test_create_text_generator_32k_model appears to be unrelated.

@@ -189,5 +189,9 @@
uid: bigframes.ml.remote.VertexAIModel
name: remote
name: bigframes.ml
- items:
- name: Bigquery Built-in Functions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: BigQuery

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, love it! This is a big milestone and will allow for future expansion of BigQuery SQL APIs, including those without a direct analogue to pandas methods.

@tswast tswast enabled auto-merge (squash) April 30, 2024 19:23
@tswast tswast merged commit 9963f85 into main Apr 30, 2024
15 of 16 checks passed
@tswast tswast deleted the main_chelsealin_arrayagg branch April 30, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants