Skip to content

fix: LabelEncoder params consistent with Sklearn #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2023
Merged

fix: LabelEncoder params consistent with Sklearn #60

merged 5 commits into from
Sep 26, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners September 25, 2023 21:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 25, 2023
@ashleyxuu ashleyxuu requested a review from GarrettWu September 25, 2023 21:54
@ashleyxuu ashleyxuu force-pushed the b301979435-label-encoder-consistency branch from 663cc15 to ab00cac Compare September 25, 2023 22:19
GarrettWu
GarrettWu reviewed Sep 25, 2023
View reviewed changes
GarrettWu
GarrettWu requested changes Sep 25, 2023
View reviewed changes
@ashleyxuu ashleyxuu requested a review from GarrettWu September 25, 2023 23:58
@ashleyxuu ashleyxuu self-assigned this Sep 26, 2023
@ashleyxuu ashleyxuu merged commit 632caec into main Sep 26, 2023
@ashleyxuu ashleyxuu deleted the b301979435-label-encoder-consistency branch September 26, 2023 04:17
@release-please release-please bot mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@ashleyxuu ashleyxuu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleyxuu @GarrettWu