Skip to content

fix: include all names in MultiIndex repr #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 2, 2024

docs: include Index in table-of-contents

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issues 332528378 and 329451344 🦕

docs: include Index in table-of-contents
@tswast tswast requested review from a team as code owners April 2, 2024 19:38
@tswast tswast requested a review from milkshakeiii April 2, 2024 19:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 2, 2024
@@ -460,14 +465,6 @@ def __init__(
super().__init__(series_or_dataframe._block)
self._whole_frame = series_or_dataframe

@property
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant with superclass.

@@ -370,3 +370,42 @@ def test_index_isin(scalars_df_index, scalars_pandas_df_index):
bf_series,
check_names=False,
)


def test_multiindex_name_is_none(session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, tests.

@tswast tswast merged commit b188146 into main Apr 3, 2024
16 checks passed
@tswast tswast deleted the b329451344-multi-index-names branch April 3, 2024 13:43
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
docs: include Index in table-of-contents (#564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants