-
Notifications
You must be signed in to change notification settings - Fork 48
fix: include all names in MultiIndex repr #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: include Index in table-of-contents
tswast
commented
Apr 2, 2024
@@ -460,14 +465,6 @@ def __init__( | |||
super().__init__(series_or_dataframe._block) | |||
self._whole_frame = series_or_dataframe | |||
|
|||
@property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant with superclass.
milkshakeiii
reviewed
Apr 2, 2024
@@ -370,3 +370,42 @@ def test_index_isin(scalars_df_index, scalars_pandas_df_index): | |||
bf_series, | |||
check_names=False, | |||
) | |||
|
|||
|
|||
def test_multiindex_name_is_none(session): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, tests.
milkshakeiii
approved these changes
Apr 2, 2024
Genesis929
pushed a commit
that referenced
this pull request
Apr 9, 2024
docs: include Index in table-of-contents (#564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery-dataframes API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: include Index in table-of-contents
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issues 332528378 and 329451344 🦕