Skip to content

feat: Add a unique session_id to Session and allow cleaning up sessions #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
May 3, 2024
Merged

feat: Add a unique session_id to Session and allow cleaning up sessions #553

merged 59 commits into from
May 3, 2024

Conversation

milkshakeiii
Copy link
Contributor

@milkshakeiii milkshakeiii commented Mar 30, 2024 •
edited
Loading

  • temporary tables will have the session id in their names
  • session.close() will delete temporary tables that were created using the session.
  • add pandas.get_default_session_id()
  • add manual_cleanup_by_session_id(session_id: str). this is slow but allows users to clean up if they lost the session object

@milkshakeiii milkshakeiii requested review from a team as code owners March 30, 2024 04:06
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 30, 2024
@milkshakeiii milkshakeiii requested a review from tswast March 30, 2024 04:06
@milkshakeiii milkshakeiii changed the title feat: Add a unique session_id to Session, enabling manual cleanup feat: Add a unique session_id to Session and allow cleaning up sessions (based on id) Mar 31, 2024
@milkshakeiii milkshakeiii requested a review from a team as a code owner April 1, 2024 18:17
@milkshakeiii milkshakeiii requested a review from parthea April 1, 2024 18:17
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 1, 2024
@milkshakeiii milkshakeiii changed the title feat: Add a unique session_id to Session and allow cleaning up sessions (based on id) feat: Add a unique session_id to Session and allow cleaning up sessions Apr 1, 2024
@milkshakeiii milkshakeiii removed request for a team and parthea April 2, 2024 01:21
@milkshakeiii milkshakeiii requested a review from tswast April 17, 2024 16:09
tswast
tswast requested changes Apr 23, 2024
View reviewed changes
@milkshakeiii milkshakeiii requested a review from tswast May 2, 2024 01:48
tswast
tswast reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple minor things before we merge.

@milkshakeiii milkshakeiii added the automerge Merge the pull request once unit tests and other checks pass. label May 2, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c8d4e23 into main May 3, 2024
15 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the b331971774-clean-up-tables branch May 3, 2024 01:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2024
@release-please release-please bot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milkshakeiii @tswast