Skip to content

fix: loosen filter items tests to accomodate shifting pandas impl #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: loosen filter items tests to accomodate shifting pandas impl #41

merged 1 commit into from
Sep 21, 2023

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners September 20, 2023 22:36
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 20, 2023
milkshakeiii
milkshakeiii reviewed Sep 20, 2023
View reviewed changes
tests/system/small/test_dataframe.py
pd.testing.assert_frame_equal(
bf_result,
pd_result,
bf_result.sort_index(axis=1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing comments.

@milkshakeiii
Copy link
Contributor

LGTM

@ashleyxuu
Copy link
Contributor

Could you rename the commit message following the convention: http://conventionalcommits.org

@TrevorBergeron TrevorBergeron changed the title Loosen filter items tests to accomodate shifting pandas impl fix: loosen filter items tests to accomodate shifting pandas impl Sep 21, 2023
@TrevorBergeron
Copy link
Contributor Author

Could you rename the commit message following the convention: http://conventionalcommits.org

done

@TrevorBergeron TrevorBergeron merged commit edabdbb into main Sep 21, 2023
@TrevorBergeron TrevorBergeron deleted the fix_filter branch September 21, 2023 00:22
@release-please release-please bot mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milkshakeiii milkshakeiii milkshakeiii approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @milkshakeiii @ashleyxuu