feat: update cut to work without labels = False and show intervals as dict #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Genesis929
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Genesis929
changed the title
Genesis929
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
shobsi
reviewed
Jan 23, 2024
| 3 {'left_exclusive': 7.5, 'right_inclusive': 10.0} | ||
| dtype: struct<left_exclusive: double, right_inclusive: double>[pyarrow] | ||
|
|
||
| Cut with an integer (equal-width bins) and labels=False: |
There was a problem hiding this comment.
It seems labels=True is also acceptable. Can we include a code sample for that?
There was a problem hiding this comment.
Was adding this to avoid the confusing case in pandas that labels can be false but can not be true, so I made labels = True works the same as labels = None. But it would appear this may be more confusing. Changed the code back so that now labels won't be able to be True as in pandas.
shobsi
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Code example updates:
https://screenshot.googleplex.com/ApQyMsLXCByk7z8
https://screenshot.googleplex.com/5jFfvntpbX5djv3
Fixes #<issue_number_goes_here> 🦕