-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add remote vertex model support #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also update docs/template/toc.yml
file and docs/reference/bigframe.ml
file to auto-sync the docs changes.
|
||
Args: | ||
endpoint (str): | ||
Vertex AI https endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give an example of the endpoints? For example, I saw "https://us-central1-aiplatform.googleapis.com/v1/projects/1084210331973/locations/us-central1/endpoints/3193318217619603456"
in your test. Might be give users some hints how to find the endpoints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User needs to deploy the model by themselves then they can find the endpoint, as well as the input/output schema. Such as https://screenshot.googleplex.com/49NX9PYEbBFNeMH
Could you also add the log_adapter annotation to the new Class? |
Done. |
done |
@@ -108,6 +108,12 @@ | |||
- name: PaLM2TextEmbeddingGenerator | |||
uid: bigframes.ml.llm.PaLM2TextEmbeddingGenerator | |||
name: llm | |||
- items: | |||
- name: Overview | |||
uid: bigframes.ml.remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It's better to put this in alphabetic order.
b/299356085