Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent KeyError in bpd.concat with empty DF and struct/array types DF #1568

Merged
merged 2 commits into from
Mar 30, 2025
Merged

fix: prevent KeyError in bpd.concat with empty DF and struct/array types DF #1568

merged 2 commits into from
Mar 30, 2025
+16 −4

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Mar 28, 2025 •
edited
Loading

Fixes internal issue 407107482 🦕

@chelsea-lin chelsea-lin requested a review from GarrettWu March 28, 2025 21:31
@chelsea-lin chelsea-lin requested review from a team as code owners March 28, 2025 21:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 28, 2025
@GarrettWu
Copy link
Contributor

Thanks for the fix.

@chelsea-lin chelsea-lin changed the title fix: KeyError at literal_to_ibis_scalar method fix: KeyError when bpd.concat with an empty DF and an DF with struct/array types Mar 28, 2025
@chelsea-lin chelsea-lin changed the title fix: KeyError when bpd.concat with an empty DF and an DF with struct/array types fix: prevent KeyError in bpd.concat with empty DF and struct/array types DF Mar 28, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_multimodelissue branch from 13f805d to f2750ca Compare March 29, 2025 06:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 29, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_multimodelissue branch 2 times, most recently from 301df30 to 66c4e98 Compare March 29, 2025 06:18
@chelsea-lin chelsea-lin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 29, 2025
@bigframes-bot bigframes-bot removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 29, 2025
@chelsea-lin chelsea-lin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2025
@chelsea-lin chelsea-lin enabled auto-merge (squash) March 30, 2025 03:08
@chelsea-lin chelsea-lin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2025
@bigframes-bot bigframes-bot removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 30, 2025
@chelsea-lin chelsea-lin merged commit b4da1cf into main Mar 30, 2025
28 of 34 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_multimodelissue branch March 30, 2025 03:16
@release-please release-please bot mentioned this pull request Mar 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@rey-esp rey-esp

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chelsea-lin @GarrettWu @bigframes-bot @rey-esp