Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use restructured text to allow publishing to PyPI #1565

Merged
merged 5 commits into from
Mar 31, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 28, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners March 28, 2025 20:35
@tswast tswast requested a review from shobsi March 28, 2025 20:35
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 28, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 28, 2025
@tswast tswast enabled auto-merge (squash) March 28, 2025 20:46
@tswast tswast changed the title docs: use restructured text to avoid PyPI security docs: use restructured text to avoid PyPI security issues Mar 28, 2025
@tswast tswast changed the title docs: use restructured text to avoid PyPI security issues docs: use restructured text to allow publishing to PyPI Mar 28, 2025
@tswast tswast disabled auto-merge March 28, 2025 20:46
@tswast tswast enabled auto-merge (squash) March 28, 2025 20:46
@tswast
Copy link
Collaborator Author

tswast commented Mar 31, 2025

Presubmit test failure:

_________________ test_bq_session_create_temp_table_clustered __________________
[gw0] linux -- Python 3.12.7 /tmpfs/src/github/python-bigquery-dataframes/.nox/system-3-12/bin/python

bigquery_client = <google.cloud.bigquery.client.Client object at 0x152ebcbca4e0>

    def test_bq_session_create_temp_table_clustered(bigquery_client: bigquery.Client):
        session_resource_manager = bigquery_session.SessionResourceManager(
            bigquery_client, "US"
        )
        cluster_cols = ["string field", "bool field"]
    
        session_table_ref = session_resource_manager.create_temp_table(
            TEST_SCHEMA, cluster_cols=cluster_cols
        )
        session_resource_manager._keep_session_alive()
    
        result_table = bigquery_client.get_table(session_table_ref)
        assert result_table.schema == TEST_SCHEMA
        assert result_table.clustering_fields == cluster_cols
    
        session_resource_manager.close()
>       with pytest.raises(google.api_core.exceptions.NotFound):
E       Failed: DID NOT RAISE <class 'google.api_core.exceptions.NotFound'>

[tests/system/small/test_bq_sessions.py:60](https://cs.corp.google.com/piper///depot/google3/tests/system/small/test_bq_sessions.py?l=60): Failed

Looks like it's happening on main, too.

@tswast tswast disabled auto-merge March 31, 2025 13:23
@tswast tswast merged commit d1e9ec2 into main Mar 31, 2025
22 of 24 checks passed
@tswast tswast deleted the tswast-readme-syntax branch March 31, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants