feat: allow input_types, output_type, and dataset to be used positionally in remote_function
#1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitionally in `remote_function`
product-auto-label
bot
added
size: m
tswast
commented
Mar 28, 2025
| # Make sure that the input/output types can be used positionally. | ||
| # This avoids the worst of the breaking change from 1.x to 2.x. | ||
| [int], | ||
| int, | ||
| dataset=dataset_id_not_created, |
There was a problem hiding this comment.
I missed this one, but I think it's good to have some tests with the keyword version of the parameter too.
4 tasks
shobsi
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards internal issue 394661567 🦕