Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change default ingress setting for remote_function to internal-only #1544

Merged
merged 6 commits into from
Mar 27, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 26, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 389837742 🦕

@shobsi shobsi requested review from a team as code owners March 26, 2025 01:55
@shobsi shobsi requested a review from tswast March 26, 2025 01:55
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 26, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 26, 2025
@tswast tswast enabled auto-merge (squash) March 27, 2025 15:06
@tswast tswast merged commit c848a80 into main Mar 27, 2025
19 of 24 checks passed
@tswast tswast deleted the shobs-ingress-settings branch March 27, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants