Skip to content

fix: fix the merge issue between 1424 and 1373 #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

fix: fix the merge issue between 1424 and 1373 #1461

merged 3 commits into from
Mar 6, 2025

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Mar 5, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jialuoo jialuoo requested a review from chelsea-lin March 5, 2025 23:45
@jialuoo jialuoo self-assigned this Mar 5, 2025
@jialuoo jialuoo requested review from a team as code owners March 5, 2025 23:45
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 5, 2025
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fixing!

@jialuoo jialuoo merged commit 7b6e361 into main Mar 6, 2025
23 checks passed
@jialuoo jialuoo deleted the fix-1424 branch March 6, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants