feat: warn when the BigFrames version is more than a year old #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
|
Doctest failures are These appear to be the usual remote functions flakiness. |
tswast
reviewed
Mar 6, 2025
bigframes/version.py
Outdated
| __release_date__, "%Y-%m-%d" | ||
| ) > datetime.timedelta(days=365): | ||
| msg = f"Your BigFrames version {__version__} is beyond the support period. Please update to the lastest version." | ||
| warnings.warn(msg) |
There was a problem hiding this comment.
Let's use a custom category in bigframes.exceptions, so that folks can filter these out if they really want to.
Also, doing this at import time isn't the best, as sometimes the import might be done before the user actually sees it (e.g. on notebook startup if colab adds some bigframes-specific hooks, for example). Can we move this to session creation?
There was a problem hiding this comment.
Sure. Moved the check to session.init
tswast
reviewed
Mar 6, 2025
bigframes/version.py
Outdated
| if datetime.datetime.today() - datetime.datetime.strptime( | ||
| __release_date__, "%Y-%m-%d" | ||
| ) > datetime.timedelta(days=365): | ||
| msg = f"Your BigFrames version {__version__} is beyond the support period. Please update to the lastest version." |
There was a problem hiding this comment.
This feels a bit too precise. Support policies can change. Let's just say it's greater than 1 year old.
sycai
changed the title
tswast
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.