Skip to content

Rolling function not working as described in the docs #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesselhuising opened this issue Feb 7, 2025 · 6 comments
Closed

Rolling function not working as described in the docs #1375

wesselhuising opened this issue Feb 7, 2025 · 6 comments
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API.

Comments

@wesselhuising
Copy link

In the docs, there is the same explanation for using rolling windows as when using Pandas. Although, in the case of BigFrames only a int is accepted while the docs state different. In this way, I can't use something like a str (7d) or a timedelta. These options are pretty vital to the rolling method in Pandas. Is there something I am overlooking (I looked in the source code of BigFrames and it seems that only an int is accepted as its arguments).

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 7, 2025
@tswast tswast assigned chelsea-lin and unassigned rey-esp Mar 10, 2025
@tswast
Copy link
Collaborator

tswast commented Mar 10, 2025

Thanks for the report! Assigning to @chelsea-lin as this week's oncall to investigate.

Also, CC @sycai who I believe has been assigned a similar issue.

@chelsea-lin chelsea-lin assigned sycai and unassigned chelsea-lin Mar 13, 2025
@chelsea-lin
Copy link
Contributor

Thank you. I've reassigned this to @sycai, who are already assigned on a related internal issue, 388916840.

@wesselhuising
Copy link
Author

Any update on this?

@sycai
Copy link
Contributor

sycai commented Mar 31, 2025

Hello, @wesselhuising !

We are actively filling the gaps between BigQuery Dataframe and Pandas. So far, the closed parameter has been added to rolling() (#1539), and the change has been released in 1.42.0. The on parameter and time-based range rolling are our next goals.

You can get notification via our CHANGELOG https://cloud.google.com/python/docs/reference/bigframes/latest/changelog and GitHub repository (https://github.com/googleapis/python-bigquery-dataframes).

Thank you very much!

@sycai
Copy link
Contributor

sycai commented Apr 14, 2025

Hey @wesselhuising !

Just want you to know that I have merged the PR: #1605 that enables time range rolling on dataframes and series.

The change is expected to be shipped in our next release.

Thank you very much!

@wesselhuising
Copy link
Author

Thank you very much, that is some great news! Looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API.
Projects
None yet
Development

No branches or pull requests

5 participants