Skip to content

perf: Prevent inlining of remote ops #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

perf: Prevent inlining of remote ops #1347

merged 1 commit into from
Feb 3, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 31, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 31, 2025
@TrevorBergeron TrevorBergeron requested a review from shobsi January 31, 2025 22:30
@TrevorBergeron TrevorBergeron marked this pull request as ready for review January 31, 2025 22:30
@TrevorBergeron TrevorBergeron requested review from a team as code owners January 31, 2025 22:30
@tswast
Copy link
Collaborator

tswast commented Feb 3, 2025

@TrevorBergeron Can you please provide some more context around this change?

@TrevorBergeron
Copy link
Contributor Author

@TrevorBergeron Can you please provide some more context around this change?

Basically, remote functions were being merged into subsequent selects, possibly inlining multiple times into different references. This was causing the SQL engine to call the remote function with duplicate calls. This change stops us from inlining remote function op SQL.

@TrevorBergeron TrevorBergeron merged commit 012081a into main Feb 3, 2025
22 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the no_inline branch February 3, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants