feat: add support for creating a Matrix Factorization model #1330

rey-esp · 2025-01-28T14:47:14Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…I public dataset In response to feedback on internal change 662899733.

bigframes/ml/decomposition.py

Co-authored-by: Tim Sweña (Swast) <[email protected]>

third_party/bigframes_vendored/sklearn/decomposition/_mf.py

…docs model Co-authored-by: Tim Sweña (Swast) <[email protected]>

…docs fit Co-authored-by: Tim Sweña (Swast) <[email protected]>

third_party/bigframes_vendored/sklearn/decomposition/_mf.py

tswast · 2025-03-28T16:27:43Z

Re: e2e error

>       assert reloaded_model.rating_col == "ratings"
E       AssertionError: assert 'rating' == 'ratings'

This is the correct assertion. Adding a rating_col @property to the MatrixFactorization class should fix it.

Co-authored-by: Tim Sweña (Swast) <[email protected]>

E Expected: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', trial_id=['index_column_id']) E Actual: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', index_col=['index_column_id'])

tswast

So cool! Thanks for your patience and persistence on this.

Several commits added since these changes were requested.

tswast and others added 4 commits September 4, 2024 09:26

docs: update title of pypi notebook example to reflect use of the PyP…

6783a0a

…I public dataset In response to feedback on internal change 662899733.

feat: add support for creating a Matrix Factorization model

1d39560

feat: add support for creating a Matrix Factorization model

e19c262

feat: add support for creating a Matrix Factorization model

1bef4a2

product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 28, 2025

Merge branch 'main' into b338873783-matrix-factorization

d157cd7

tswast reviewed Jan 28, 2025

View reviewed changes

rey-esp and others added 7 commits January 28, 2025 11:10

Update bigframes/ml/decomposition.py

e336bde

Co-authored-by: Tim Sweña (Swast) <[email protected]>

Update bigframes/ml/decomposition.py

d5f713a

Co-authored-by: Tim Sweña (Swast) <[email protected]>

Update bigframes/ml/decomposition.py

5e3e443

Co-authored-by: Tim Sweña (Swast) <[email protected]>

Merge branch 'main' into b338873783-matrix-factorization

34a60bc

rating_col

c116e8a

(nearly) complete class

dedef39

Merge branch 'main' into b338873783-matrix-factorization

e5165a9

rey-esp force-pushed the b338873783-matrix-factorization branch from 5f4f9d3 to e5165a9 Compare January 28, 2025 21:18

product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 28, 2025

rey-esp added 5 commits January 28, 2025 15:31

Merge branch 'main' into b338873783-matrix-factorization

05eb854

removem print()

2787178

removem print()

8c66e07

adding recommend

086b4dd

Merge branch 'main' into b338873783-matrix-factorization

8ed3ccd

tswast reviewed Jan 29, 2025

View reviewed changes

third_party/bigframes_vendored/sklearn/decomposition/_mf.py Outdated Show resolved Hide resolved

third_party/bigframes_vendored/sklearn/decomposition/_mf.py Outdated Show resolved Hide resolved

third_party/bigframes_vendored/sklearn/decomposition/_mf.py Outdated Show resolved Hide resolved

tswast marked this pull request as ready for review January 29, 2025 17:25

tswast requested review from a team as code owners January 29, 2025 17:25

tswast requested a review from sycai January 29, 2025 17:25

blunderbuss-gcf bot assigned jiaxunwu Jan 29, 2025

Merge branch 'main' into b338873783-matrix-factorization

1b4eef9

rey-esp and others added 3 commits March 27, 2025 10:53

Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py - …

2cbc2e3

…docs model Co-authored-by: Tim Sweña (Swast) <[email protected]>

Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py - …

0a5aefb

…docs fit Co-authored-by: Tim Sweña (Swast) <[email protected]>

Merge branch 'main' into b338873783-matrix-factorization

d484f77

tswast reviewed Mar 28, 2025

View reviewed changes

third_party/bigframes_vendored/sklearn/decomposition/_mf.py Outdated Show resolved Hide resolved

Update third_party/bigframes_vendored/sklearn/decomposition/_mf.py

366e0ab

rey-esp and others added 18 commits March 31, 2025 08:37

Merge branch 'main' into b338873783-matrix-factorization

1eaa708

remove errors and tests

56ee623

Update bigframes/ml/decomposition.py

c942418

Co-authored-by: Tim Sweña (Swast) <[email protected]>

Update bigframes/ml/decomposition.py

e0ef53e

Co-authored-by: Tim Sweña (Swast) <[email protected]>

Update bigframes/ml/decomposition.py

5018182

Co-authored-by: Tim Sweña (Swast) <[email protected]>

Merge branch 'main' into b338873783-matrix-factorization

c088a76

passing system test

f9397f1

E AssertionError: expected call not found.

b439120

E Expected: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', trial_id=['index_column_id']) E Actual: read_gbq('SELECT * FROM ML.RECOMMEND(MODEL ..,\n (input_X_sql))', index_col=['index_column_id'])

Merge branch 'main' into b338873783-matrix-factorization

ffe0f33

Merge branch 'main' into b338873783-matrix-factorization

b2698ef

Merge branch 'main' into b338873783-matrix-factorization

69c8fba

same # of elements in each

8a614c5

Merge branch 'main' into b338873783-matrix-factorization

9d71c86

attempt

c2b4795

Merge branch 'main' into b338873783-matrix-factorization

cd20ffc

doc fix

cf6e5be

doc fix

da230b4

Merge branch 'main' into b338873783-matrix-factorization

8927072

tswast approved these changes Apr 1, 2025

View reviewed changes

tswast enabled auto-merge (squash) April 1, 2025 19:42

tswast merged commit b5297f9 into main Apr 1, 2025
19 of 24 checks passed

tswast deleted the b338873783-matrix-factorization branch April 1, 2025 20:07

release-please bot mentioned this pull request Apr 1, 2025

chore(main): release 2.0.0 #1552

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for creating a Matrix Factorization model #1330

feat: add support for creating a Matrix Factorization model #1330

rey-esp commented Jan 28, 2025

tswast commented Mar 28, 2025

tswast left a comment

feat: add support for creating a Matrix Factorization model #1330

feat: add support for creating a Matrix Factorization model #1330

Conversation

rey-esp commented Jan 28, 2025

tswast commented Mar 28, 2025

tswast left a comment

Choose a reason for hiding this comment