Skip to content

docs: add snippet for predicting classifications using a boosted tree model #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Nov 14, 2024

… model

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Nov 14, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@tswast
Copy link
Collaborator

tswast commented Nov 15, 2024

We'll need to wait for #1142 before we can merge this because of the tests, which need the model to be created via Python.

I don't think you will need to make any changes to this code sample besides resolving the merge conflicts to put this sample after the create model one, though.

@rey-esp rey-esp marked this pull request as ready for review November 20, 2024 16:18
@rey-esp rey-esp requested review from a team as code owners November 20, 2024 16:18
@@ -62,7 +62,7 @@ def test_boosted_tree_model(random_model_id: str) -> None:
replace=True,
)
# [END bigquery_dataframes_bqml_boosted_tree_create]
# [START bigquery_dataframes_bqml_boosted_tree_explain]
# [START bigquery_dataframes_bqml_boosted_tree_evaluate]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best not to rename these, though in this case it should be OK since we haven't added the samples to cloud.google.com/bigquery/docs yet

Copy link

snippet-bot bot commented Nov 20, 2024

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rey-esp rey-esp added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
@rey-esp rey-esp merged commit e7b83f1 into main Nov 20, 2024
23 checks passed
@rey-esp rey-esp deleted the b338872698-bigframes-v3 branch November 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants