fix: update session metrics in read_gbq_query
#1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
sycai
approved these changes
Oct 15, 2024
shobsi
approved these changes
Oct 15, 2024
shobsi
changed the title
shobsi
changed the title
read_gbq_query
shobsi
changed the title
read_gbq_queryread_gbq_query
shobsi
reviewed
Oct 15, 2024
| @@ -529,6 +529,9 @@ def read_gbq_query( | |||
| configuration=configuration, | |||
| ) | |||
|
|
|||
| if self._metrics is not None: | |||
There was a problem hiding this comment.
I missed earlier, is the query_job guaranteed to have finished at this point? We should wait for the job to finish, like we do in other places before calling count_job_stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure the session metrics correctly reflect slot milliseconds after ML transform.
Fixes internal issue 372547905 🦕