Skip to content

feat: cleanup temp resources with session deletion #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 9, 2024

BEGIN_COMMIT_OVERRIDE
feat: cleanup temp resources with session deletion (#1068)

chore: improve cleanup of test remote functions (#1068)
END_COMMIT_OVERRIDE

This change expands the current cleanup process which applies only to the default US region and only those test pipelines that run the tests depending on the fixtures. Namely, it:

  1. Adds the Session class destructor, and calls close() from it.
  2. Add a nox session for cloud function cleanup and run it with doctest. This cleans up in all regions in the project.

Fixes internal issue 371360614 🦕

@shobsi shobsi requested review from a team as code owners October 9, 2024 01:28
@shobsi shobsi requested a review from Genesis929 October 9, 2024 01:28
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 9, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 9, 2024
@shobsi shobsi changed the title chore: improve cleanup of test remote functions feat: cleanup temp resources with graceful session shutdown Oct 10, 2024
@shobsi shobsi merged commit 1d5373d into main Oct 10, 2024
23 checks passed
@shobsi shobsi deleted the shobs-manage-functions-script branch October 10, 2024 19:09
@shobsi shobsi changed the title feat: cleanup temp resources with graceful session shutdown feat: cleanup temp resources with session deletion Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants