Skip to content

feat!: rename bigframes.pandas.reset_session to close_session #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Oct 12, 2023

BEGIN_COMMIT_OVERRIDE
feat!: rename bigframes.pandas.reset_session to close_session (#101)

Release-As: 0.9.0
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 12, 2023
@GarrettWu GarrettWu requested review from tswast and shobsi October 12, 2023 05:05
@GarrettWu GarrettWu marked this pull request as ready for review October 12, 2023 05:45
@GarrettWu GarrettWu requested review from a team as code owners October 12, 2023 05:45
@GarrettWu GarrettWu requested a review from nicain October 12, 2023 05:45
@tswast
Copy link
Collaborator

tswast commented Oct 12, 2023

Since we need to manually specify the version number anyway (#99 (comment)), let's label this as a breaking change. https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-both--and-breaking-change-footer

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mark as a breaking change.

Alternatively, we can leave an alias for reset_session but mark it as deprecated.

@GarrettWu GarrettWu changed the title feat: rename bigframes.pandas.reset_session to close_session feat!: rename bigframes.pandas.reset_session to close_session Oct 12, 2023
@GarrettWu
Copy link
Contributor Author

GarrettWu commented Oct 12, 2023

Let's mark as a breaking change.

Alternatively, we can leave an alias for reset_session but mark it as deprecated.

I only need to say feat! instead of feat in commit message, right? Done.

Oh just saw your link.

@GarrettWu GarrettWu requested a review from tswast October 12, 2023 17:20
@tswast tswast changed the title feat!: rename bigframes.pandas.reset_session to close_session feat!: rename bigframes.pandas.reset_session to close_session Oct 12, 2023
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 36693bf into main Oct 12, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the garrettwu-session branch October 12, 2023 22:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 18, 2023
🤖 I have created a release *beep* *boop*
---


## [0.9.0](https://togithub.com/googleapis/python-bigquery-dataframes/compare/v0.8.0...v0.9.0) (2023-10-18)


### ⚠ BREAKING CHANGES

* rename `bigframes.pandas.reset_session` to `close_session` ([#101](https://togithub.com/googleapis/python-bigquery-dataframes/issues/101))

### Features

* Add `bigframes.options.bigquery.application_name` for partner attribution ([#117](https://togithub.com/googleapis/python-bigquery-dataframes/issues/117)) ([52d64ff](https://togithub.com/googleapis/python-bigquery-dataframes/commit/52d64ffdbbab16b1d94974b543ce9080be1ec0d1))
* Add AtIndexer getitems ([#107](https://togithub.com/googleapis/python-bigquery-dataframes/issues/107)) ([752b01f](https://togithub.com/googleapis/python-bigquery-dataframes/commit/752b01ff9df114c54ed58eb96956e9ce34a8ed47))
* Rename `bigframes.pandas.reset_session` to `close_session` ([#101](https://togithub.com/googleapis/python-bigquery-dataframes/issues/101)) ([36693bf](https://togithub.com/googleapis/python-bigquery-dataframes/commit/36693bff398c23e179d9bde95d52cbaddaf85c45))
* Send BigQuery cancel request when canceling bigframes process ([#103](https://togithub.com/googleapis/python-bigquery-dataframes/issues/103)) ([e325fbb](https://togithub.com/googleapis/python-bigquery-dataframes/commit/e325fbb1c91e040d87df10f7d4d5ce53f7c052cb))
* Support external packages in `remote_function` ([#98](https://togithub.com/googleapis/python-bigquery-dataframes/issues/98)) ([ec10c4a](https://togithub.com/googleapis/python-bigquery-dataframes/commit/ec10c4a5a7833c42e28fe9e7b734bc0c4fb84b6e))
* Use ArrowDtype for STRUCT columns in `to_pandas` ([#85](https://togithub.com/googleapis/python-bigquery-dataframes/issues/85)) ([9238fad](https://togithub.com/googleapis/python-bigquery-dataframes/commit/9238fadcfa7e843be6564813ff3131893b79f8b0))


### Bug Fixes

* Support multiindex for three loc getitem overloads ([#113](https://togithub.com/googleapis/python-bigquery-dataframes/issues/113)) ([68e3cd3](https://togithub.com/googleapis/python-bigquery-dataframes/commit/68e3cd37258084d045ea1075e5e61df12c28faac))


### Performance Improvements

* If primary keys are defined, `read_gbq` avoids copying table data ([#112](https://togithub.com/googleapis/python-bigquery-dataframes/issues/112)) ([e6c0cd1](https://togithub.com/googleapis/python-bigquery-dataframes/commit/e6c0cd1777736e0fa7285da59625fbac487573bd))


### Documentation

* Add documentation for `Series.struct.field` and `Series.struct.explode` ([#114](https://togithub.com/googleapis/python-bigquery-dataframes/issues/114)) ([a6dab9c](https://togithub.com/googleapis/python-bigquery-dataframes/commit/a6dab9cdb7dd0e56c93ca96b665ab1be1baac5e5))
* Add open-source link in API doc ([#106](https://togithub.com/googleapis/python-bigquery-dataframes/issues/106)) ([db51fe3](https://togithub.com/googleapis/python-bigquery-dataframes/commit/db51fe340f644a0d7c911c11d92c8299a4be3446))
* Update ML overview API doc ([#105](https://togithub.com/googleapis/python-bigquery-dataframes/issues/105)) ([1b3f3a5](https://togithub.com/googleapis/python-bigquery-dataframes/commit/1b3f3a5374915b2833c6c1ac05670e9708f07bff))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants