resolve comments

Author: jialuoo

bigframes/functions/_function_client.py

@@ -29,7 +29,6 @@
 from bigframes_vendored import constants
 import requests
 
-from bigframes.functions._utils import get_python_version
 import bigframes.functions.function_template as bff_template
 
 if TYPE_CHECKING:
@@ -209,7 +208,7 @@ def provision_bq_managed_function(
             bq_function_args.append(f"{name_} {type_}")
 
         managed_function_options = {
-            "runtime_version": get_python_version(),
+            "runtime_version": _utils.get_python_version(),
             "entry_point": "bigframes_handler",
         }
 
@@ -347,7 +346,7 @@ def create_cloud_function(
             # TODO(shobs): Figure out how to achieve version compatibility, specially
             # when pickle (internally used by cloudpickle) guarantees that:
             # https://docs.python.org/3/library/pickle.html#:~:text=The%20pickle%20serialization%20format%20is,unique%20breaking%20change%20language%20boundary.
-            python_version = get_python_version(is_compat=True)
+            python_version = _utils.get_python_version(is_compat=True)
 
             # Determine an upload URL for user code
             upload_url_request = functions_v2.GenerateUploadUrlRequest(

bigframes/functions/_function_session.py

@@ -49,7 +49,6 @@
 from bigframes import clients
 import bigframes.core.compile.ibis_types
 import bigframes.exceptions as bfe
-from bigframes.functions._utils import get_python_version
 import bigframes.series as bf_series
 
 if TYPE_CHECKING:
@@ -257,9 +256,9 @@ def remote_function(
         cloud_function_max_instances: Optional[int] = None,
         cloud_function_vpc_connector: Optional[str] = None,
         cloud_function_memory_mib: Optional[int] = 1024,
-        cloud_function_ingress_settings: Literal[
-            "all", "internal-only", "internal-and-gclb"
-        ] = "all",
+        cloud_function_ingress_settings: Optional[
+            Literal["all", "internal-only", "internal-and-gclb"]
+        ] = None,
     ):
         """Decorator to turn a user defined function into a BigQuery remote function.
 
@@ -769,7 +768,7 @@ def udf(
             raise NotImplementedError()
 
         # Check the Python version.
-        python_version = get_python_version()
+        python_version = _utils.get_python_version()
         if python_version not in _MANAGED_FUNC_PYTHON_VERSIONS:
             raise RuntimeError(
                 f"Python version {python_version} is not supported yet for "

bigframes/functions/_utils.py

@@ -284,8 +284,9 @@ def get_bigframes_metadata(*, python_output_type: Optional[type] = None) -> str:
 
 
 def get_python_version(is_compat: bool = False) -> str:
-    # Cloud Run functions use the 'compat' format (e.g., python311), while
-    # managed functions use the standard format (e.g., python-3.11).
+    # Cloud Run functions use the 'compat' format (e.g., python311, see more
+    # from https://cloud.google.com/functions/docs/runtime-support#python),
+    # while managed functions use the standard format (e.g., python-3.11).
     major = sys.version_info.major
     minor = sys.version_info.minor
     return f"python{major}{minor}" if is_compat else f"python-{major}.{minor}"

bigframes/session/__init__.py

@@ -1404,7 +1404,7 @@ def remote_function(
             cloud_function_max_instances=cloud_function_max_instances,
             cloud_function_vpc_connector=cloud_function_vpc_connector,
             cloud_function_memory_mib=cloud_function_memory_mib,
-            cloud_function_ingress_settings=cloud_function_ingress_settings,  # type: ignore
+            cloud_function_ingress_settings=cloud_function_ingress_settings,
         )
 
     def udf(