Skip to content

Commit fcd0096

Browse files
authored
fix: rename teardown fixture (#1004)
1 parent e0fec36 commit fcd0096

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

tests/system/aiplatform/e2e_base.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,13 @@ def delete_bigquery_dataset(self, shared_state: Dict[str, Any]):
124124
) # Make an API request.
125125

126126
@pytest.fixture(scope="class", autouse=True)
127-
def teardown(self, shared_state: Dict[str, Any]):
127+
def tear_down_resources(self, shared_state: Dict[str, Any]):
128128
"""Delete every Vertex AI resource created during test"""
129129

130130
yield
131131

132+
# TODO(b/218310362): Add resource deletion system tests
133+
132134
# Bring all Endpoints to the front of the list
133135
# Ensures Models are undeployed first before we attempt deletion
134136
shared_state["resources"].sort(

tests/system/aiplatform/test_e2e_tabular.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
}
4747

4848

49-
@pytest.mark.usefixtures("prepare_staging_bucket", "delete_staging_bucket", "teardown")
49+
@pytest.mark.usefixtures("prepare_staging_bucket", "delete_staging_bucket")
5050
class TestEndToEndTabular(e2e_base.TestEndToEnd):
5151
"""End to end system test of the Vertex SDK with tabular data adapted from
5252
reference notebook http://shortn/_eyoNx3SN0X"""

tests/system/aiplatform/test_model_upload.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
_XGBOOST_MODEL_URI = "gs://cloud-samples-data-us-central1/vertex-ai/google-cloud-aiplatform-ci-artifacts/models/iris_xgboost/model.bst"
3333

3434

35-
@pytest.mark.usefixtures("delete_staging_bucket", "teardown")
35+
@pytest.mark.usefixtures("delete_staging_bucket")
3636
class TestModel(e2e_base.TestEndToEnd):
3737
_temp_prefix = f"{_TEST_PROJECT}-vertex-staging-{_TEST_LOCATION}"
3838

0 commit comments

Comments
 (0)