Skip to content

Commit f249353

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
docs: Fix incorrect field in log_time_series_metrics_sample
PiperOrigin-RevId: 605759888
1 parent 90d95d7 commit f249353

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

samples/model-builder/experiment_tracking/log_time_series_metrics_sample.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def log_time_series_metrics_sample(
3030
):
3131
aiplatform.init(experiment=experiment_name, project=project, location=location)
3232

33-
aiplatform.start_run(run_name=run_name, resume=True)
33+
aiplatform.start_run(run=run_name, resume=True)
3434

3535
aiplatform.log_time_series_metrics(metrics=metrics, step=step, wall_time=wall_time)
3636

samples/model-builder/experiment_tracking/log_time_series_metrics_sample_test.py

+13-4
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,12 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
import pytest
16-
1715
from experiment_tracking import log_time_series_metrics_sample
1816
import test_constants as constants
1917

2018

21-
@pytest.mark.usefixtures("mock_sdk_init", "mock_start_run")
22-
def test_log_time_series_metrics_sample(mock_log_time_series_metrics):
19+
def test_log_time_series_metrics_sample(
20+
mock_log_time_series_metrics, mock_start_run, mock_sdk_init):
2321

2422
log_time_series_metrics_sample.log_time_series_metrics_sample(
2523
experiment_name=constants.EXPERIMENT_NAME,
@@ -31,6 +29,17 @@ def test_log_time_series_metrics_sample(mock_log_time_series_metrics):
3129
location=constants.LOCATION,
3230
)
3331

32+
mock_sdk_init.assert_called_with(
33+
experiment=constants.EXPERIMENT_NAME,
34+
project=constants.PROJECT,
35+
location=constants.LOCATION
36+
)
37+
38+
mock_start_run.assert_called_with(
39+
run=constants.EXPERIMENT_RUN_NAME,
40+
resume=True,
41+
)
42+
3443
mock_log_time_series_metrics.assert_called_with(
3544
metrics=constants.METRICS,
3645
step=constants.STEP,

0 commit comments

Comments
 (0)