Skip to content

Commit b5404e7

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
feat: Fix typo in Vertex Feature Store SDK.
PiperOrigin-RevId: 627854409
1 parent c56dd50 commit b5404e7

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

tests/unit/vertexai/test_feature_online_store.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -483,9 +483,9 @@ def test_create_embedding_fv(
483483
FeatureView.BigQuerySource(uri="hi", entity_id_columns=["entity_id"]),
484484
index_config=IndexConfig(
485485
embedding_column="embedding",
486-
filter_column=["currency_code", "gender", "shipping_country_codes"],
486+
dimensions=1536,
487+
filter_columns=["currency_code", "gender", "shipping_country_codes"],
487488
crowding_column="crowding",
488-
dimentions=1536,
489489
distance_measure_type=DistanceMeasureType.SQUARED_L2_DISTANCE,
490490
algorithm_config=TreeAhConfig(),
491491
),

vertexai/resources/preview/feature_store/utils.py

+12-8
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,11 @@ class IndexConfig:
130130
"""Configuration options for the Vertex FeatureView for embedding."""
131131

132132
embedding_column: str
133-
filter_column: List[str]
134-
crowding_column: str
135-
dimentions: Optional[int]
136-
distance_measure_type: DistanceMeasureType
133+
dimensions: int
137134
algorithm_config: AlgorithmConfig
135+
filter_columns: Optional[List[str]] = None
136+
crowding_column: Optional[str] = None
137+
distance_measure_type: Optional[DistanceMeasureType] = None
138138

139139
def as_dict(self) -> Dict[str, Any]:
140140
"""Returns the configuration as a dictionary.
@@ -144,11 +144,15 @@ def as_dict(self) -> Dict[str, Any]:
144144
"""
145145
config = {
146146
"embedding_column": self.embedding_column,
147-
"filter_columns": self.filter_column,
148-
"crowding_column": self.crowding_column,
149-
"embedding_dimension": self.dimentions,
150-
"distance_measure_type": self.distance_measure_type.value,
147+
"embedding_dimension": self.dimensions,
151148
}
149+
if self.distance_measure_type is not None:
150+
config["distance_measure_type"] = self.distance_measure_type.value
151+
if self.filter_columns is not None:
152+
config["filter_columns"] = self.filter_columns
153+
if self.crowding_column is not None:
154+
config["crowding_column"] = self.crowding_column
155+
152156
if isinstance(self.algorithm_config, TreeAhConfig):
153157
config["tree_ah_config"] = self.algorithm_config.as_dict()
154158
else:

0 commit comments

Comments
 (0)