chore: add list_feature_views() in feature views

PiperOrigin-RevId: 711554371

Author: vertex-sdk-bot

tests/unit/vertexai/conftest.py

@@ -63,6 +63,7 @@
     _TEST_FG1_F1,
     _TEST_FG1_F2,
     _TEST_FG1_FM1,
+    _TEST_FV_LIST,
     _TEST_FV1,
     _TEST_FV3,
     _TEST_OPTIMIZED_EMBEDDING_FV,
@@ -443,6 +444,16 @@ def get_rag_fv_mock():
         yield get_rag_fv_mock
 
 
+@pytest.fixture
+def list_fv_mock():
+    with patch.object(
+        feature_online_store_admin_service_client.FeatureOnlineStoreAdminServiceClient,
+        "list_feature_views",
+    ) as list_fv:
+        list_fv.return_value = _TEST_FV_LIST
+        yield list_fv
+
+
 @pytest.fixture
 def create_bq_fv_mock():
     with patch.object(

tests/unit/vertexai/test_feature_online_store.py

@@ -42,12 +42,15 @@
     _TEST_ESF_OPTIMIZED_FOS_LABELS,
     _TEST_ESF_OPTIMIZED_FOS_PATH,
     _TEST_FOS_LIST,
+    _TEST_FV_LIST,
     _TEST_FV1_BQ_URI,
     _TEST_FV1_ENTITY_ID_COLUMNS,
     _TEST_FV1_ID,
     _TEST_FV1_LABELS,
     _TEST_FV1_PATH,
-    _TEST_FV3_BQ_URI,
+    _TEST_FV2_ID,
+    _TEST_FV2_LABELS,
+    _TEST_FV2_PATH,
     _TEST_FV3_ID,
     _TEST_FV3_LABELS,
     _TEST_FV3_PATH,
@@ -617,65 +620,39 @@ def test_create_rag_fv_bad_uri_raises_error(get_fos_mock):
         )
 
 
-@pytest.mark.parametrize("create_request_timeout", [None, 1.0])
-@pytest.mark.parametrize("sync", [True, False])
-def test_create_rag_fv(
-    create_request_timeout,
-    sync,
+def test_list_feature_views(
     get_fos_mock,
-    create_rag_fv_mock,
-    get_rag_fv_mock,
-    fos_logger_mock,
+    list_fv_mock,
 ):
     aiplatform.init(project=_TEST_PROJECT, location=_TEST_LOCATION)
-    fos = FeatureOnlineStore(_TEST_BIGTABLE_FOS1_ID)
 
-    rag_fv = fos.create_feature_view(
-        _TEST_FV3_ID,
-        FeatureViewVertexRagSource(uri=_TEST_FV3_BQ_URI),
-        labels=_TEST_FV3_LABELS,
-        create_request_timeout=create_request_timeout,
-    )
+    fos = FeatureOnlineStore(_TEST_BIGTABLE_FOS1_ID)
+    feature_views = fos.list_feature_views()
 
-    if not sync:
-        fos.wait()
+    list_fv_mock.assert_called_once_with(request={"parent": _TEST_BIGTABLE_FOS1_PATH})
+    assert len(feature_views) == len(_TEST_FV_LIST)
 
-    # When creating, the FeatureView object doesn't have the path set.
-    expected_fv = types.feature_view.FeatureView(
-        vertex_rag_source=types.feature_view.FeatureView.VertexRagSource(
-            uri=_TEST_FV3_BQ_URI,
-        ),
-        labels=_TEST_FV3_LABELS,
+    fv_eq(
+        feature_views[0],
+        name=_TEST_FV1_ID,
+        resource_name=_TEST_FV1_PATH,
+        project=_TEST_PROJECT,
+        location=_TEST_LOCATION,
+        labels=_TEST_FV1_LABELS,
     )
-    create_rag_fv_mock.assert_called_with(
-        parent=_TEST_BIGTABLE_FOS1_PATH,
-        feature_view=expected_fv,
-        feature_view_id=_TEST_FV3_ID,
-        metadata=(),
-        timeout=create_request_timeout,
+    fv_eq(
+        feature_views[1],
+        name=_TEST_FV2_ID,
+        resource_name=_TEST_FV2_PATH,
+        project=_TEST_PROJECT,
+        location=_TEST_LOCATION,
+        labels=_TEST_FV2_LABELS,
     )
-
     fv_eq(
-        fv_to_check=rag_fv,
+        feature_views[2],
         name=_TEST_FV3_ID,
         resource_name=_TEST_FV3_PATH,
         project=_TEST_PROJECT,
         location=_TEST_LOCATION,
         labels=_TEST_FV3_LABELS,
     )
-
-    fos_logger_mock.assert_has_calls(
-        [
-            call("Creating FeatureView"),
-            call(
-                f"Create FeatureView backing LRO: {create_rag_fv_mock.return_value.operation.name}"
-            ),
-            call(
-                "FeatureView created. Resource name: projects/test-project/locations/us-central1/featureOnlineStores/my_fos1/featureViews/my_fv3"
-            ),
-            call("To use this FeatureView in another session:"),
-            call(
-                "feature_view = aiplatform.FeatureView('projects/test-project/locations/us-central1/featureOnlineStores/my_fos1/featureViews/my_fv3')"
-            ),
-        ]
-    )

tests/unit/vertexai/test_feature_view.py

@@ -80,16 +80,6 @@ def fv_logger_mock():
         yield logger_mock
 
 
-@pytest.fixture
-def list_fv_mock():
-    with patch.object(
-        feature_online_store_admin_service_client.FeatureOnlineStoreAdminServiceClient,
-        "list_feature_views",
-    ) as list_fv:
-        list_fv.return_value = _TEST_FV_LIST
-        yield list_fv
-
-
 @pytest.fixture
 def delete_fv_mock():
     with patch.object(

vertexai/resources/preview/feature_store/feature_online_store.py

@@ -18,6 +18,7 @@
 import enum
 from typing import (
     Dict,
+    List,
     Optional,
     Sequence,
     Tuple,
@@ -577,3 +578,33 @@ def create_feature_view(
         )
 
         return feature_view_obj
+
+    def list_feature_views(
+        self,
+        project: Optional[str] = None,
+        location: Optional[str] = None,
+        credentials: Optional[auth_credentials.Credentials] = None,
+    ) -> List[FeatureView]:
+        """Lists feature views under this feature online store.
+
+        Args:
+            project:
+                Project to list feature views in. If unset, the project set in
+                aiplatform.init will be used.
+            location:
+                Location to list feature views in. If not set, location set in
+                aiplatform.init will be used.
+            credentials:
+                Custom credentials to use to list feature views. Overrides
+                credentials set in aiplatform.init.
+
+        Returns:
+            List of feature views under this feature online store.
+        """
+
+        return FeatureView.list(
+            feature_online_store_id=self.name,
+            project=project,
+            location=location,
+            credentials=credentials,
+        )

vertexai/resources/preview/feature_store/feature_view.py

@@ -231,6 +231,8 @@ def list(
         cls,
         feature_online_store_id: str,
         filter: Optional[str] = None,
+        project: Optional[str] = None,
+        location: Optional[str] = None,
         credentials: Optional[auth_credentials.Credentials] = None,
     ) -> List["FeatureView"]:
         """List all feature view under feature_online_store_id.
@@ -246,6 +248,12 @@ def list(
                 Parentfeature online store ID.
             filter:
                 Filter to apply on the returned feature online store.
+            project:
+                Project to use to get a list of feature views. If unset, the
+                project set in aiplatform.init will be used.
+            location:
+                Location to use to get a list feature views. If not set,
+                location set in aiplatform.init will be used.
             credentials:
                 Custom credentials to use to get a list of feature views.
                 Overrides credentials set in aiplatform.init.
@@ -255,7 +263,12 @@ def list(
         """
         from .feature_online_store import FeatureOnlineStore
 
-        fos = FeatureOnlineStore(name=feature_online_store_id)
+        fos = FeatureOnlineStore(
+            name=feature_online_store_id,
+            project=project,
+            location=location,
+            credentials=credentials,
+        )
         return cls._list(
             filter=filter, credentials=credentials, parent=fos.resource_name
         )