Skip to content

Commit 4e2d87f

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
fix: Generate uuid run_name when run_name_prefix is not specified.
PiperOrigin-RevId: 641964421
1 parent cad035c commit 4e2d87f

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

google/cloud/aiplatform/tensorboard/uploader_utils.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,12 @@ def _create_or_get_run_resource(
222222
location = m[2]
223223
tensorboard = m[3]
224224
experiment = m[4]
225+
if not run_name or run_name == ".":
226+
run_name = str(uuid.uuid4())
225227
experiment_run = experiment_run_resource.ExperimentRun.get(
226228
project=project, location=location, run_name=run_name
227229
)
228230
if not experiment_run:
229-
if not run_name:
230-
run_name = str(uuid.uuid4())
231231
experiment_run = experiment_run_resource.ExperimentRun.create(
232232
project=project,
233233
location=location,

tests/unit/aiplatform/test_uploader.py

+8-2
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,12 @@ def test_start_uploading_scalars(
665665
self.assertEqual(mock_tracker.blob_tracker.call_count, 0)
666666

667667
@parameterized.parameters(
668-
{"existing_experiment": None}, {"existing_experiment": _TEST_EXPERIMENT_NAME}
668+
{"existing_experiment": None, "one_platform_run_name": None},
669+
{"existing_experiment": None, "one_platform_run_name": "."},
670+
{
671+
"existing_experiment": _TEST_EXPERIMENT_NAME,
672+
"one_platform_run_name": _TEST_ONE_PLATFORM_RUN_NAME,
673+
},
669674
)
670675
@patch.object(
671676
uploader_utils.OnePlatformResourceManager,
@@ -686,6 +691,7 @@ def test_start_uploading_scalars_one_shot(
686691
experiment_tracker_mock,
687692
run_resource_mock,
688693
existing_experiment,
694+
one_platform_run_name,
689695
):
690696
"""Check that one-shot uploading stops without AbortUploadError."""
691697

@@ -734,7 +740,7 @@ def batch_create_time_series(parent, requests):
734740

735741
mock_rate_limiter = mock.create_autospec(uploader_utils.RateLimiter)
736742
mock_tracker = mock.MagicMock()
737-
run_resource_mock.return_value = _TEST_ONE_PLATFORM_RUN_NAME
743+
run_resource_mock.return_value = one_platform_run_name
738744
with mock.patch.object(
739745
upload_tracker, "UploadTracker", return_value=mock_tracker
740746
):

0 commit comments

Comments
 (0)