Skip to content

Commit 2ba404f

Browse files
authored
fix: loosen assertions for system test featurestore (#1040)
b/221238283
1 parent d221e6b commit 2ba404f

File tree

1 file changed

+36
-18
lines changed

1 file changed

+36
-18
lines changed

tests/system/aiplatform/test_featurestore.py

+36-18
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ def test_create_get_list_featurestore(self, shared_state):
6161
project=e2e_base._PROJECT, location=e2e_base._LOCATION,
6262
)
6363

64-
base_list_featurestores = len(aiplatform.Featurestore.list())
65-
shared_state["base_list_searched_features"] = len(aiplatform.Feature.search())
66-
6764
featurestore_id = self._make_display_name(key=_TEST_FEATURESTORE_ID).replace(
6865
"-", "_"
6966
)[:60]
@@ -79,7 +76,9 @@ def test_create_get_list_featurestore(self, shared_state):
7976
assert featurestore.resource_name == get_featurestore.resource_name
8077

8178
list_featurestores = aiplatform.Featurestore.list()
82-
assert (len(list_featurestores) - base_list_featurestores) == 1
79+
assert get_featurestore.resource_name in [
80+
featurestore.resource_name for featurestore in list_featurestores
81+
]
8382

8483
def test_create_get_list_entity_types(self, shared_state):
8584

@@ -121,7 +120,9 @@ def test_create_get_list_entity_types(self, shared_state):
121120
list_entity_types = aiplatform.EntityType.list(
122121
featurestore_name=featurestore_name
123122
)
124-
assert len(list_entity_types) == 2
123+
assert get_movie_entity_type.resource_name in [
124+
entity_type.resource_name for entity_type in list_entity_types
125+
]
125126

126127
def test_create_get_list_features(self, shared_state):
127128

@@ -134,9 +135,6 @@ def test_create_get_list_features(self, shared_state):
134135
project=e2e_base._PROJECT, location=e2e_base._LOCATION,
135136
)
136137

137-
list_user_features = user_entity_type.list_features()
138-
assert len(list_user_features) == 0
139-
140138
# User Features
141139
user_age_feature = user_entity_type.create_feature(
142140
feature_id=_TEST_USER_AGE_FEATURE_ID, value_type="INT64"
@@ -179,7 +177,16 @@ def test_create_get_list_features(self, shared_state):
179177
)
180178

181179
list_user_features = user_entity_type.list_features()
182-
assert len(list_user_features) == 3
180+
list_user_feature_resource_names = [
181+
feature.resource_name for feature in list_user_features
182+
]
183+
184+
assert get_user_age_feature.resource_name in list_user_feature_resource_names
185+
assert get_user_gender_feature.resource_name in list_user_feature_resource_names
186+
assert (
187+
get_user_liked_genres_feature.resource_name
188+
in list_user_feature_resource_names
189+
)
183190

184191
def test_ingest_feature_values(self, shared_state, caplog):
185192

@@ -223,13 +230,28 @@ def test_batch_create_features(self, shared_state):
223230
_TEST_MOVIE_AVERAGE_RATING_FEATURE_ID: {"value_type": "DOUBLE"},
224231
}
225232

226-
list_movie_features = movie_entity_type.list_features()
227-
assert len(list_movie_features) == 0
228-
229233
movie_entity_type.batch_create_features(feature_configs=movie_feature_configs)
230234

235+
get_movie_title_feature = movie_entity_type.get_feature(
236+
feature_id=_TEST_MOVIE_TITLE_FEATURE_ID
237+
)
238+
get_movie_genres_feature = movie_entity_type.get_feature(
239+
feature_id=_TEST_MOVIE_GENRES_FEATURE_ID
240+
)
241+
get_movie_avg_rating_feature = movie_entity_type.get_feature(
242+
feature_id=_TEST_MOVIE_AVERAGE_RATING_FEATURE_ID
243+
)
244+
231245
list_movie_features = movie_entity_type.list_features()
232-
assert len(list_movie_features) == 3
246+
movie_feature_resource_names = [
247+
feature.resource_name for feature in list_movie_features
248+
]
249+
250+
assert get_movie_title_feature.resource_name in movie_feature_resource_names
251+
assert get_movie_genres_feature.resource_name in movie_feature_resource_names
252+
assert (
253+
get_movie_avg_rating_feature.resource_name in movie_feature_resource_names
254+
)
233255

234256
def test_ingest_feature_values_from_df_using_feature_time_column_and_online_read_multiple_entities(
235257
self, shared_state, caplog
@@ -400,16 +422,12 @@ def test_ingest_feature_values_from_df_using_feature_time_datetime_and_online_re
400422

401423
def test_search_features(self, shared_state):
402424

403-
assert shared_state["base_list_searched_features"] is not None
404-
405425
aiplatform.init(
406426
project=e2e_base._PROJECT, location=e2e_base._LOCATION,
407427
)
408428

409429
list_searched_features = aiplatform.Feature.search()
410-
assert (
411-
len(list_searched_features) - shared_state["base_list_searched_features"]
412-
) == 6
430+
assert len(list_searched_features) >= 1
413431

414432
def test_batch_serve_to_df(self, shared_state, caplog):
415433

0 commit comments

Comments
 (0)