Skip to content

Commit 00977be

Browse files
committed
Restore the parameter ordering as requested by reviewer
The parameter default values had to be removed due to Python's syntax.
1 parent 701bbbd commit 00977be

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

google/cloud/aiplatform/training_jobs.py

+12-6
Original file line numberDiff line numberDiff line change
@@ -1015,6 +1015,8 @@ class _CustomTrainingJob(_TrainingJob):
10151015

10161016
def __init__(
10171017
self,
1018+
# TODO: Make display_name parameter fully optional in next major release
1019+
display_name: Optional[str],
10181020
container_uri: str,
10191021
model_serving_container_image_uri: Optional[str] = None,
10201022
model_serving_container_predict_route: Optional[str] = None,
@@ -1027,7 +1029,6 @@ def __init__(
10271029
model_instance_schema_uri: Optional[str] = None,
10281030
model_parameters_schema_uri: Optional[str] = None,
10291031
model_prediction_schema_uri: Optional[str] = None,
1030-
display_name: Optional[str] = None,
10311032
project: Optional[str] = None,
10321033
location: Optional[str] = None,
10331034
credentials: Optional[auth_credentials.Credentials] = None,
@@ -1554,6 +1555,8 @@ class CustomTrainingJob(_CustomTrainingJob):
15541555

15551556
def __init__(
15561557
self,
1558+
# TODO: Make display_name parameter fully optional in next major release
1559+
display_name: Optional[str],
15571560
script_path: str,
15581561
container_uri: str,
15591562
requirements: Optional[Sequence[str]] = None,
@@ -1568,7 +1571,6 @@ def __init__(
15681571
model_instance_schema_uri: Optional[str] = None,
15691572
model_parameters_schema_uri: Optional[str] = None,
15701573
model_prediction_schema_uri: Optional[str] = None,
1571-
display_name: Optional[str] = None,
15721574
project: Optional[str] = None,
15731575
location: Optional[str] = None,
15741576
credentials: Optional[auth_credentials.Credentials] = None,
@@ -2385,6 +2387,8 @@ class CustomContainerTrainingJob(_CustomTrainingJob):
23852387

23862388
def __init__(
23872389
self,
2390+
# TODO: Make display_name parameter fully optional in next major release
2391+
display_name: Optional[str],
23882392
container_uri: str,
23892393
command: Sequence[str] = None,
23902394
model_serving_container_image_uri: Optional[str] = None,
@@ -2398,7 +2402,6 @@ def __init__(
23982402
model_instance_schema_uri: Optional[str] = None,
23992403
model_parameters_schema_uri: Optional[str] = None,
24002404
model_prediction_schema_uri: Optional[str] = None,
2401-
display_name: Optional[str] = None,
24022405
project: Optional[str] = None,
24032406
location: Optional[str] = None,
24042407
credentials: Optional[auth_credentials.Credentials] = None,
@@ -3193,13 +3196,14 @@ class AutoMLTabularTrainingJob(_TrainingJob):
31933196

31943197
def __init__(
31953198
self,
3199+
# TODO: Make display_name parameter fully optional in next major release
3200+
display_name: Optional[str],
31963201
optimization_prediction_type: str,
31973202
optimization_objective: Optional[str] = None,
31983203
column_specs: Optional[Dict[str, str]] = None,
31993204
column_transformations: Optional[List[Dict[str, Dict[str, str]]]] = None,
32003205
optimization_objective_recall_value: Optional[float] = None,
32013206
optimization_objective_precision_value: Optional[float] = None,
3202-
display_name: Optional[str] = None,
32033207
project: Optional[str] = None,
32043208
location: Optional[str] = None,
32053209
credentials: Optional[auth_credentials.Credentials] = None,
@@ -5184,6 +5188,8 @@ class CustomPythonPackageTrainingJob(_CustomTrainingJob):
51845188

51855189
def __init__(
51865190
self,
5191+
# TODO: Make display_name parameter fully optional in next major release
5192+
display_name: Optional[str],
51875193
python_package_gcs_uri: str,
51885194
python_module_name: str,
51895195
container_uri: str,
@@ -5198,7 +5204,6 @@ def __init__(
51985204
model_instance_schema_uri: Optional[str] = None,
51995205
model_parameters_schema_uri: Optional[str] = None,
52005206
model_prediction_schema_uri: Optional[str] = None,
5201-
display_name: Optional[str] = None,
52025207
project: Optional[str] = None,
52035208
location: Optional[str] = None,
52045209
credentials: Optional[auth_credentials.Credentials] = None,
@@ -6355,10 +6360,11 @@ class AutoMLTextTrainingJob(_TrainingJob):
63556360

63566361
def __init__(
63576362
self,
6363+
# TODO: Make display_name parameter fully optional in next major release
6364+
display_name: Optional[str],
63586365
prediction_type: str,
63596366
multi_label: bool = False,
63606367
sentiment_max: int = 10,
6361-
display_name: Optional[str] = None,
63626368
project: Optional[str] = None,
63636369
location: Optional[str] = None,
63646370
credentials: Optional[auth_credentials.Credentials] = None,

0 commit comments

Comments
 (0)