Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Commit cc4cc51

Browse files
feat!: drop node8 support, support for async iterators (#145)
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. New feature: methods with pagination now support async iteration.
1 parent 428e14c commit cc4cc51

17 files changed

+3423
-1436
lines changed

.eslintrc.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"extends": "./node_modules/gts"
3+
}

.eslintrc.yml

-15
This file was deleted.

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
node: [8, 10, 12, 13]
12+
node: [10, 12, 13]
1313
steps:
1414
- uses: actions/checkout@v2
1515
- uses: actions/setup-node@v1

.prettierrc

-8
This file was deleted.

.prettierrc.js

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// Copyright 2020 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
module.exports = {
16+
...require('gts/.prettierrc.json')
17+
}

package.json

+6-4
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,18 @@
2525
"reCAPTCHA Enterprise API"
2626
],
2727
"dependencies": {
28-
"google-gax": "^1.9.0"
28+
"google-gax": "^2.0.1"
2929
},
3030
"devDependencies": {
3131
"@types/mocha": "^7.0.0",
3232
"@types/node": "^12.0.0",
33+
"@types/sinon": "^7.5.2",
3334
"c8": "^7.0.0",
3435
"eslint": "^6.0.0",
3536
"eslint-config-prettier": "^6.0.0",
3637
"eslint-plugin-node": "^11.0.0",
3738
"eslint-plugin-prettier": "^3.0.0",
38-
"gts": "^1.0.0",
39+
"gts": "2.0.0-alpha.9",
3940
"jsdoc": "^3.6.2",
4041
"jsdoc-fresh": "^1.0.1",
4142
"jsdoc-region-tag": "^1.0.2",
@@ -44,8 +45,9 @@
4445
"null-loader": "^3.0.0",
4546
"pack-n-play": "^1.0.0-2",
4647
"prettier": "^1.17.1",
48+
"sinon": "^9.0.1",
4749
"ts-loader": "^6.2.1",
48-
"typescript": "^3.7.0",
50+
"typescript": "^3.8.3",
4951
"webpack": "^4.41.2",
5052
"webpack-cli": "^3.3.10"
5153
},
@@ -66,6 +68,6 @@
6668
},
6769
"license": "Apache-2.0",
6870
"engines": {
69-
"node": ">=8.10.0"
71+
"node": ">=10"
7072
}
7173
}

samples/test/samples.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ describe('Quickstart', () => {
2626
it('should run quickstart', () => {
2727
// TODO: work on setting up a proper integration test.
2828
assert.throws(() => {
29-
execSync(`node quickstart.js 123456`, {cwd});
29+
execSync('node quickstart.js 123456', {cwd});
3030
}, /Permission denied on resource project #123456/);
3131
});
3232
});

0 commit comments

Comments
 (0)