Skip to content

Fix: Remove unused "long" dependency from firestore proto #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 9, 2025
Merged

Fix: Remove unused "long" dependency from firestore proto #2324

merged 15 commits into from
Apr 9, 2025

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 4, 2025 •
edited
Loading

Owl-bot auto added the "long" dependey, which is not used, to firestore proto: #2050.

fix #2322

@milaGGL milaGGL requested review from a team as code owners April 4, 2025 19:42
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Apr 4, 2025
@milaGGL milaGGL changed the title Remove unused "long" dependency from firestore proto Fix: Remove unused "long" dependency from firestore proto Apr 4, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 4, 2025
@milaGGL
Copy link
Contributor Author

milaGGL commented Apr 8, 2025

This is blocked by node version update as unit tests are failing.

@milaGGL milaGGL added the status: blocked Resolving the issue is dependent on other work. label Apr 8, 2025
@milaGGL milaGGL removed the status: blocked Resolving the issue is dependent on other work. label Apr 9, 2025
@MarkDuckworth MarkDuckworth added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 9, 2025
MarkDuckworth
MarkDuckworth reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm re-running owl bot post-processor to make sure any autogenerated code will not overwrite any changes.

@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2025
@milaGGL milaGGL merged commit 5937b93 into main Apr 9, 2025
17 checks passed
@milaGGL milaGGL deleted the mila/fix-long-dependeny-issue branch April 9, 2025 18:53
@release-please release-please bot mentioned this pull request Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undecalred dependency to "long" in types
4 participants
@milaGGL @MarkDuckworth @sofisl @yoshi-kokoro