Addressing feedback

Author: schmidt-sebastian

src/index.js

@@ -216,7 +216,7 @@ class Firestore {
    * `Timestamp` instead.
    * <br/>NOTE: in the future `timestampsInSnapshots: true` will become the
    * default and this option will be removed so you should change your code to
-   * use Timestamp now and opt-in to this new behavior as soon as you can.
+   * use `Timestamp` now and opt-in to this new behavior as soon as you can.
    */
   constructor(options) {
     options = extend({}, options, {

src/validate.js

@@ -56,7 +56,9 @@ module.exports = validators => {
           return false;
         }
         if (value < min || value > max) {
-          throw new Error(`Value must be within [${min}, ${max}] inclusive.`);
+          throw new Error(
+            `Value must be within [${min}, ${max}] inclusive, but was: ${value}`
+          );
         }
         return true;
       },
@@ -67,7 +69,9 @@ module.exports = validators => {
           return false;
         }
         if (value < min || value > max) {
-          throw new Error(`Value must be within [${min}, ${max}] inclusive.`);
+          throw new Error(
+            `Value must be within [${min}, ${max}] inclusive, but was: ${value}`
+          );
         }
         return true;
       },

test/document.js

@@ -470,11 +470,11 @@ describe('serialize document', function() {
 
     assert.throws(() => {
       new Firestore.GeoPoint(91, 0);
-    }, /Argument "latitude" is not a valid number. Value must be within \[-90, 90] inclusive/);
+    }, /Argument "latitude" is not a valid number. Value must be within \[-90, 90] inclusive, but was: 91/);
 
     assert.throws(() => {
       new Firestore.GeoPoint(90, 181);
-    }, /Argument "longitude" is not a valid number. Value must be within \[-180, 180] inclusive/);
+    }, /Argument "longitude" is not a valid number. Value must be within \[-180, 180] inclusive, but was: 181/);
   });
 
   it('resolves infinite nesting', function() {

test/timestamp.js

@@ -209,12 +209,12 @@ describe('timestamps', function() {
 
     assert.throws(
       () => new Firestore.Timestamp(0, -1),
-      /Argument "nanoseconds" is not a valid integer. Value must be within \[0, 999999999] inclusive/
+      /Argument "nanoseconds" is not a valid integer. Value must be within \[0, 999999999] inclusive, but was: -1/
     );
 
     assert.throws(
       () => new Firestore.Timestamp(0, 1000000000),
-      /Argument "nanoseconds" is not a valid integer. Value must be within \[0, 999999999] inclusive/
+      /Argument "nanoseconds" is not a valid integer. Value must be within \[0, 999999999] inclusive, but was: 1000000000/
     );
   });
 });

types/firestore.d.ts

@@ -72,7 +72,7 @@ declare namespace FirebaseFirestore {
      *
      * NOTE: in the future `timestampsInSnapshots: true` will become the
      * default and this option will be removed so you should change your code to
-     * use Timestamp now and opt-in to this new behavior as soon as you can.
+     * use `Timestamp` now and opt-in to this new behavior as soon as you can.
      */
     timestampsInSnapshots?: boolean;