build!: update library to use Node 12 (#945)

* build!: Update library to use Node 12

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: sofisl

.github/sync-repo-settings.yaml

@@ -9,9 +9,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (10)
       - test (12)
       - test (14)
+      - test (16)
       - cla/google
       - windows
       - OwlBot Post Processor

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [10, 12, 14]
+        node: [12, 14, 16]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

.kokoro/continuous/node10/common.cfg

@@ -45,7 +45,7 @@
     "arrify": "^2.0.1",
     "concat-stream": "^2.0.0",
     "extend": "^3.0.2",
-    "google-gax": "^2.24.1",
+    "google-gax": "^3.0.1",
     "is": "^3.3.0",
     "split-array-stream": "^2.0.0",
     "stream-events": "^1.0.5"
@@ -60,23 +60,23 @@
     "@types/proxyquire": "^1.3.28",
     "@types/sinon": "^10.0.0",
     "c8": "^7.1.0",
-    "gts": "^3.0.0",
+    "gts": "^3.1.0",
     "js-yaml": "^4.0.0",
     "jsdoc": "^3.6.3",
     "jsdoc-fresh": "^1.0.2",
     "jsdoc-region-tag": "^1.0.4",
     "linkinator": "^2.0.3",
-    "mocha": "^8.0.0",
+    "mocha": "^9.2.2",
     "null-loader": "^4.0.0",
     "p-queue": "^6.6.1",
     "pack-n-play": "^1.0.0-2",
     "proxyquire": "^2.1.3",
     "sinon": "^14.0.0",
     "ts-loader": "^8.0.0",
-    "typescript": "^3.8.3",
+    "typescript": "^4.6.4",
     "webpack-cli": "^4.0.0"
   },
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   }
 }

.kokoro/continuous/node10/docs.cfg

@@ -8,7 +8,7 @@
   ],
   "repository": "googleapis/nodejs-datastore",
   "engines": {
-    "node": ">=10"
+    "node": ">=12.0.0"
   },
   "scripts": {
     "test": "mocha --timeout=600000"

.kokoro/continuous/node10/test.cfg

@@ -180,7 +180,11 @@ export namespace entity {
         try {
           return this.typeCastFunction!(this.value);
         } catch (error) {
-          error.message = `integerTypeCastFunction threw an error:\n\n  - ${error.message}`;
+          (
+            error as Error
+          ).message = `integerTypeCastFunction threw an error:\n\n  - ${
+            (error as Error).message
+          }`;
           throw error;
         }
       } else {

.kokoro/continuous/node8/common.cfg

@@ -611,13 +611,13 @@ class Datastore extends DatastoreRequest {
     const gaxOpts = options.gaxOptions || {};
 
     const reqOpts = {
-      pageSize: gaxOpts.pageSize,
-      pageToken: gaxOpts.pageToken,
+      pageSize: (gaxOpts as GetIndexesOptions).pageSize,
+      pageToken: (gaxOpts as GetIndexesOptions).pageToken,
       ...options,
     };
 
-    delete gaxOpts.pageSize;
-    delete gaxOpts.pageToken;
+    delete (gaxOpts as GetIndexesOptions).pageSize;
+    delete (gaxOpts as GetIndexesOptions).pageToken;
     delete (reqOpts as CallOptions).autoPaginate;
     delete (reqOpts as GetIndexesOptions).gaxOptions;
 

.kokoro/continuous/node8/test.cfg

@@ -727,7 +727,7 @@ class DatastoreRequest {
       } catch (e) {
         // using setImmediate here to make sure this doesn't throw a
         // synchronous error
-        setImmediate(onResultSet, e);
+        setImmediate(onResultSet, e as Error);
         return;
       }
 
@@ -880,7 +880,7 @@ class DatastoreRequest {
           // Even a failed rollback should be transparent.
           // RE: https://github.com/GoogleCloudPlatform/gcloud-node/pull/1369#discussion_r66833976
         }
-        callback!(err);
+        callback!(err as Error);
       }
     });
   }

.kokoro/presubmit/node10/common.cfg

@@ -1675,8 +1675,11 @@ describe('entity', () => {
       try {
         entity.keyFromKeyProto(keyProtoInvalid);
       } catch (e) {
-        assert.strictEqual(e.name, 'InvalidKey');
-        assert.strictEqual(e.message, 'Ancestor keys require an id or name.');
+        assert.strictEqual((e as Error).name, 'InvalidKey');
+        assert.strictEqual(
+          (e as Error).message,
+          'Ancestor keys require an id or name.'
+        );
         done();
       }
     });
@@ -1756,8 +1759,11 @@ describe('entity', () => {
       try {
         entity.keyToKeyProto(key);
       } catch (e) {
-        assert.strictEqual(e.name, 'InvalidKey');
-        assert.strictEqual(e.message, 'A key should contain at least a kind.');
+        assert.strictEqual((e as Error).name, 'InvalidKey');
+        assert.strictEqual(
+          (e as Error).message,
+          'A key should contain at least a kind.'
+        );
         done();
       }
     });
@@ -1771,8 +1777,11 @@ describe('entity', () => {
       try {
         entity.keyToKeyProto(key);
       } catch (e) {
-        assert.strictEqual(e.name, 'InvalidKey');
-        assert.strictEqual(e.message, 'Ancestor keys require an id or name.');
+        assert.strictEqual((e as Error).name, 'InvalidKey');
+        assert.strictEqual(
+          (e as Error).message,
+          'Ancestor keys require an id or name.'
+        );
         done();
       }
     });