Skip to content

Commit 593acc3

Browse files
fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors (#1896)
1 parent 96f88eb commit 593acc3

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

google-cloud-firestore/clirr-ignored-differences.xml

+6
Original file line numberDiff line numberDiff line change
@@ -314,4 +314,10 @@
314314
<method>com.google.cloud.firestore.Query getQuery()</method>
315315
</difference>
316316

317+
<difference>
318+
<className>com/google/cloud/firestore/StreamableQuery</className>
319+
<differenceType>7009</differenceType>
320+
<method>void internalStream(*)</method>
321+
</difference>
322+
317323
</differences>

google-cloud-firestore/src/main/java/com/google/cloud/firestore/StreamableQuery.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static com.google.common.collect.Lists.reverse;
2121

2222
import com.google.api.core.ApiFuture;
23+
import com.google.api.core.InternalApi;
2324
import com.google.api.core.SettableApiFuture;
2425
import com.google.api.gax.rpc.ApiStreamObserver;
2526
import com.google.api.gax.rpc.ResponseObserver;
@@ -49,6 +50,7 @@
4950
* `isRetryableWithCursor`. Retrying with a cursor means that the StreamableQuery can be resumed
5051
* where it failed by first calling `startAfter(lastDocumentReceived)`.
5152
*/
53+
@InternalApi
5254
public abstract class StreamableQuery<SnapshotType> {
5355
final Query.QueryOptions options;
5456
final FirestoreRpcContext<?> rpcContext;
@@ -237,7 +239,7 @@ public void onCompleted() {
237239
}
238240
}
239241

240-
protected void internalStream(
242+
void internalStream(
241243
final ApiStreamObserver<RunQueryResponse> runQueryResponseObserver,
242244
final long startTimeNanos,
243245
@Nullable final ByteString transactionId,

0 commit comments

Comments
 (0)