Skip to content

Commit 5662b26

Browse files
authored
chore: Override the version of protobuf-bom to 4.28.3 in libraries-bom. (#6836)
1 parent 2c49bcf commit 5662b26

File tree

5 files changed

+21
-2
lines changed

5 files changed

+21
-2
lines changed

libraries-bom-protobuf3/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.google.cloud</groupId>
55
<artifactId>libraries-bom-protobuf3</artifactId>
6-
<version>0.2.0-SNAPSHOT</version><!-- {x-version-update:libraries-bom-protobuf3:current} -->
6+
<version>26.50.0-SNAPSHOT</version><!-- {x-version-update:libraries-bom:current} -->
77
<packaging>pom</packaging>
88

99
<parent>

libraries-bom/pom.xml

+11
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,17 @@
5959

6060
<dependencyManagement>
6161
<dependencies>
62+
<!-- This section overrides the protobuf version specified in first-party-dependencies. This is to provide customers a bom that includes protobuf-java 4.x.
63+
We will upgrade protobuf-bom in first-party-dependencies once we feel comfortable that most customers would not have conflict with protobuf-java 4.x.
64+
This section has to be specified before first-party-dependencies, please do not move it. -->
65+
<dependency>
66+
<groupId>com.google.protobuf</groupId>
67+
<artifactId>protobuf-bom</artifactId>
68+
<version>4.28.3</version>
69+
<type>pom</type>
70+
<scope>import</scope>
71+
</dependency>
72+
6273
<!-- first-party-dependencies is part of java-shared-dependencies
6374
BOM in https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/first-party-dependencies/pom.xml.
6475
This includes Guava, Protobuf, gRPC, Google Auth Libraries, etc. -->

release-note-generation/src/main/java/com/google/cloud/ReleaseNoteGeneration.java

+3
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,9 @@ private void printKeyCoreLibraryDependencies(Bom bom) {
182182
.append("- Google Cloud Core: ")
183183
.append(versionlessCoordinatesToVersion.get("com.google.cloud:google-cloud-core"))
184184
.append("\n");
185+
report
186+
.append("If you encounter compatibility issues with protobuf-java 4.x, please update your codebase and dependencies to ensure compatibility. If this is not feasible, use libraries-bom-protobuf3 as a workaround. libraries-bom-protobuf3 includes the same client libraries and library versions as libraries-bom.")
187+
.append("\n");
185188
}
186189

187190
private void printApiReferenceLink() {

renovate.json

+6
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,12 @@
6969
"^com.fasterxml.jackson.core"
7070
],
7171
"groupName": "jackson dependencies"
72+
},
73+
{
74+
"matchPackagePatterns": [
75+
"^com.google.protobuf:"
76+
],
77+
"enabled": false
7278
}
7379
],
7480
"semanticCommits": "enabled",

versions.txt

-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@
33

44
google-cloud-bom:0.230.0:0.231.0-SNAPSHOT
55
libraries-bom:26.49.0:26.50.0-SNAPSHOT
6-
libraries-bom-protobuf3:0.1.0:0.2.0-SNAPSHOT
76
java-cloud-bom-tests:0.45.0:0.46.0-SNAPSHOT
87
full-convergence-check:0.48.0:0.49.0-SNAPSHOT

0 commit comments

Comments
 (0)