Skip to content

Commit bdec5e5

Browse files
yoshi-automationbusunkim96
authored andcommitted
fix(recommender): deprecate resource name helper methods (via synth) (#9863)
1 parent 3e11788 commit bdec5e5

File tree

4 files changed

+20
-9
lines changed

4 files changed

+20
-9
lines changed

recommender/docs/_static/custom.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
div#python2-eol {
22
border-color: red;
33
border-width: medium;
4-
}
4+
}

recommender/docs/_templates/layout.html

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
{% extends "!layout.html" %}
23
{%- block content %}
34
{%- if theme_fixed_sidebar|lower == 'true' %}

recommender/google/cloud/recommender_v1beta1/gapic/recommender_client.py

+12-2
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
8181

8282
@classmethod
8383
def recommendation_path(cls, project, location, recommender, recommendation):
84-
"""Return a fully-qualified recommendation string."""
84+
"""DEPRECATED. Return a fully-qualified recommendation string."""
85+
warnings.warn(
86+
"Resource name helper functions are deprecated.",
87+
PendingDeprecationWarning,
88+
stacklevel=1,
89+
)
8590
return google.api_core.path_template.expand(
8691
"projects/{project}/locations/{location}/recommenders/{recommender}/recommendations/{recommendation}",
8792
project=project,
@@ -92,7 +97,12 @@ def recommendation_path(cls, project, location, recommender, recommendation):
9297

9398
@classmethod
9499
def recommender_path(cls, project, location, recommender):
95-
"""Return a fully-qualified recommender string."""
100+
"""DEPRECATED. Return a fully-qualified recommender string."""
101+
warnings.warn(
102+
"Resource name helper functions are deprecated.",
103+
PendingDeprecationWarning,
104+
stacklevel=1,
105+
)
96106
return google.api_core.path_template.expand(
97107
"projects/{project}/locations/{location}/recommenders/{recommender}",
98108
project=project,

recommender/synth.metadata

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
{
2-
"updateTime": "2019-10-05T12:31:38.542410Z",
2+
"updateTime": "2019-11-20T13:28:29.755927Z",
33
"sources": [
44
{
55
"generator": {
66
"name": "artman",
7-
"version": "0.38.0",
8-
"dockerImage": "googleapis/artman@sha256:0d2f8d429110aeb8d82df6550ef4ede59d40df9062d260a1580fce688b0512bf"
7+
"version": "0.42.1",
8+
"dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
99
}
1010
},
1111
{
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "ceb8e2fb12f048cc94caae532ef0b4cf026a78f3",
16-
"internalRef": "272971705"
15+
"sha": "16543773103e2619d2b5f52456264de5bb9be104",
16+
"internalRef": "281423227"
1717
}
1818
},
1919
{
2020
"template": {
2121
"name": "python_library",
2222
"origin": "synthtool.gcp",
23-
"version": "2019.5.2"
23+
"version": "2019.10.17"
2424
}
2525
}
2626
],

0 commit comments

Comments
 (0)