fix(vision): deprecate resource name helper methods (via synth) (#9866)

yoshi-automation · busunkim96 · commit 909e0261d302 · 2019-11-20T09:31:57.000-08:00
diff --git a/vision/docs/_static/custom.css b/vision/docs/_static/custom.css
@@ -1,4 +1,4 @@
 div#python2-eol {
 	border-color: red;
 	border-width: medium;
-}
+} 
diff --git a/vision/docs/_templates/layout.html b/vision/docs/_templates/layout.html
@@ -1,3 +1,4 @@
+
 {% extends "!layout.html" %}
 {%- block content %}
 {%- if theme_fixed_sidebar|lower == 'true' %}
diff --git a/vision/google/cloud/vision_v1/gapic/product_search_client.py b/vision/google/cloud/vision_v1/gapic/product_search_client.py
@@ -96,7 +96,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def location_path(cls, project, location):
-        """Return a fully-qualified location string."""
+        """DEPRECATED. Return a fully-qualified location string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}",
             project=project,
@@ -105,7 +110,12 @@ def location_path(cls, project, location):
 
     @classmethod
     def product_path(cls, project, location, product):
-        """Return a fully-qualified product string."""
+        """DEPRECATED. Return a fully-qualified product string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/products/{product}",
             project=project,
@@ -115,7 +125,12 @@ def product_path(cls, project, location, product):
 
     @classmethod
     def product_set_path(cls, project, location, product_set):
-        """Return a fully-qualified product_set string."""
+        """DEPRECATED. Return a fully-qualified product_set string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/productSets/{product_set}",
             project=project,
@@ -125,7 +140,12 @@ def product_set_path(cls, project, location, product_set):
 
     @classmethod
     def reference_image_path(cls, project, location, product, reference_image):
-        """Return a fully-qualified reference_image string."""
+        """DEPRECATED. Return a fully-qualified reference_image string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/products/{product}/referenceImages/{reference_image}",
             project=project,
diff --git a/vision/google/cloud/vision_v1p3beta1/gapic/product_search_client.py b/vision/google/cloud/vision_v1p3beta1/gapic/product_search_client.py
@@ -93,7 +93,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def location_path(cls, project, location):
-        """Return a fully-qualified location string."""
+        """DEPRECATED. Return a fully-qualified location string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}",
             project=project,
@@ -102,7 +107,12 @@ def location_path(cls, project, location):
 
     @classmethod
     def product_path(cls, project, location, product):
-        """Return a fully-qualified product string."""
+        """DEPRECATED. Return a fully-qualified product string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/products/{product}",
             project=project,
@@ -112,7 +122,12 @@ def product_path(cls, project, location, product):
 
     @classmethod
     def product_set_path(cls, project, location, product_set):
-        """Return a fully-qualified product_set string."""
+        """DEPRECATED. Return a fully-qualified product_set string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/productSets/{product_set}",
             project=project,
@@ -122,7 +137,12 @@ def product_set_path(cls, project, location, product_set):
 
     @classmethod
     def reference_image_path(cls, project, location, product, reference_image):
-        """Return a fully-qualified reference_image string."""
+        """DEPRECATED. Return a fully-qualified reference_image string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/products/{product}/referenceImages/{reference_image}",
             project=project,
diff --git a/vision/google/cloud/vision_v1p4beta1/gapic/product_search_client.py b/vision/google/cloud/vision_v1p4beta1/gapic/product_search_client.py
@@ -94,7 +94,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def location_path(cls, project, location):
-        """Return a fully-qualified location string."""
+        """DEPRECATED. Return a fully-qualified location string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}",
             project=project,
@@ -103,7 +108,12 @@ def location_path(cls, project, location):
 
     @classmethod
     def product_path(cls, project, location, product):
-        """Return a fully-qualified product string."""
+        """DEPRECATED. Return a fully-qualified product string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/products/{product}",
             project=project,
@@ -113,7 +123,12 @@ def product_path(cls, project, location, product):
 
     @classmethod
     def product_set_path(cls, project, location, product_set):
-        """Return a fully-qualified product_set string."""
+        """DEPRECATED. Return a fully-qualified product_set string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/productSets/{product_set}",
             project=project,
@@ -123,7 +138,12 @@ def product_set_path(cls, project, location, product_set):
 
     @classmethod
     def reference_image_path(cls, project, location, product, reference_image):
-        """Return a fully-qualified reference_image string."""
+        """DEPRECATED. Return a fully-qualified reference_image string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/locations/{location}/products/{product}/referenceImages/{reference_image}",
             project=project,
diff --git a/vision/synth.metadata b/vision/synth.metadata
@@ -1,19 +1,19 @@
 {
-  "updateTime": "2019-11-06T13:44:16.072107Z",
+  "updateTime": "2019-11-20T13:38:24.545550Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.41.0",
-        "dockerImage": "googleapis/artman@sha256:75b38a3b073a7b243545f2332463096624c802bb1e56b8cb6f22ba1ecd325fa9"
+        "version": "0.42.1",
+        "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "5691fcb7c1a926b52577aa1834f31d9c50efda54",
-        "internalRef": "278731899"
+        "sha": "16543773103e2619d2b5f52456264de5bb9be104",
+        "internalRef": "281423227"
       }
     },
     {

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+`
`1`	`2`	`{% extends "!layout.html" %}`
`2`	`3`	`{%- block content %}`
`3`	`4`	`{%- if theme_fixed_sidebar\|lower == 'true' %}`
Original file line number	Diff line number	Diff line change
`@@ -1,19 +1,19 @@`
`1`	`1`	`{`
`2`		`- "updateTime": "2019-11-06T13:44:16.072107Z",`
	`2`	`+ "updateTime": "2019-11-20T13:38:24.545550Z",`
`3`	`3`	`"sources": [`
`4`	`4`	`{`
`5`	`5`	`"generator": {`
`6`	`6`	`"name": "artman",`
`7`		`- "version": "0.41.0",`
`8`		`- "dockerImage": "googleapis/artman@sha256:75b38a3b073a7b243545f2332463096624c802bb1e56b8cb6f22ba1ecd325fa9"`
	`7`	`+ "version": "0.42.1",`
	`8`	`+ "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"`
`9`	`9`	`}`
`10`	`10`	`},`
`11`	`11`	`{`
`12`	`12`	`"git": {`
`13`	`13`	`"name": "googleapis",`
`14`	`14`	`"remote": "https://github.com/googleapis/googleapis.git",`
`15`		`- "sha": "5691fcb7c1a926b52577aa1834f31d9c50efda54",`
`16`		`- "internalRef": "278731899"`
	`15`	`+ "sha": "16543773103e2619d2b5f52456264de5bb9be104",`
	`16`	`+ "internalRef": "281423227"`
`17`	`17`	`}`
`18`	`18`	`},`
`19`	`19`	`{`