File tree 2 files changed +1
-4
lines changed
2 files changed +1
-4
lines changed Original file line number Diff line number Diff line change @@ -1072,12 +1072,10 @@ def max_bad_records(self):
1072
1072
See
1073
1073
https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.load.maxBadRecords
1074
1074
"""
1075
- # XXX: should this coerce from str, like 'skip_leading_rows' below?
1076
- return self ._get_sub_prop ('maxBadRecords' )
1075
+ return _helpers ._int_or_none (self ._get_sub_prop ('maxBadRecords' ))
1077
1076
1078
1077
@max_bad_records .setter
1079
1078
def max_bad_records (self , value ):
1080
- # XXX: should this coerce to str, like 'skip_leading_rows' below?
1081
1079
self ._set_sub_prop ('maxBadRecords' , value )
1082
1080
1083
1081
@property
Original file line number Diff line number Diff line change @@ -1592,7 +1592,6 @@ def test_skip_leading_rows_setter(self):
1592
1592
config .skip_leading_rows = skip_leading_rows
1593
1593
self .assertEqual (
1594
1594
config ._properties ['load' ]['skipLeadingRows' ],
1595
- # XXX: Should this really be a str?
1596
1595
str (skip_leading_rows ))
1597
1596
1598
1597
def test_source_format_missing (self ):
You can’t perform that action at this time.
0 commit comments