Skip to content

Commit 2a920d1

Browse files
committed
Remove 'XXX' comments after resolving related question in review.
1 parent 1240481 commit 2a920d1

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

bigquery/google/cloud/bigquery/job.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -1072,12 +1072,10 @@ def max_bad_records(self):
10721072
See
10731073
https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.load.maxBadRecords
10741074
"""
1075-
# XXX: should this coerce from str, like 'skip_leading_rows' below?
1076-
return self._get_sub_prop('maxBadRecords')
1075+
return _helpers._int_or_none(self._get_sub_prop('maxBadRecords'))
10771076

10781077
@max_bad_records.setter
10791078
def max_bad_records(self, value):
1080-
# XXX: should this coerce to str, like 'skip_leading_rows' below?
10811079
self._set_sub_prop('maxBadRecords', value)
10821080

10831081
@property

bigquery/tests/unit/test_job.py

-1
Original file line numberDiff line numberDiff line change
@@ -1592,7 +1592,6 @@ def test_skip_leading_rows_setter(self):
15921592
config.skip_leading_rows = skip_leading_rows
15931593
self.assertEqual(
15941594
config._properties['load']['skipLeadingRows'],
1595-
# XXX: Should this really be a str?
15961595
str(skip_leading_rows))
15971596

15981597
def test_source_format_missing(self):

0 commit comments

Comments
 (0)