Skip to content

Fix GAPIC headers #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjwatson opened this issue Apr 15, 2017 · 8 comments
Closed

Fix GAPIC headers #2225

bjwatson opened this issue Apr 15, 2017 · 8 comments
Assignees
@lukesneeringer
Labels
api: vision Issues related to the Cloud Vision API. core

Comments

@bjwatson
Copy link

The issues with missing gccl/ and stale gapic/ version (0.1.0) needs to be fixed. This was observed with Vision. Its x-goog-api-client header is "gl-node/6.6.0 gapic/0.1.0 gax/0.12.3 grpc/1.2.4".

Then please refresh all GAPICs, and publish their associated packages to npmjs.com.

After that, please update any affect cells in the HTTP header matrix, so I can review (I think Vision is the only API using GAPIC in that matrix).
@bjwatson bjwatson added core priority: p0 Highest priority. Critical issue. P0 implies highest priority. status: acknowledged type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 15, 2017
@lukesneeringer lukesneeringer mentioned this issue Apr 17, 2017
Merged
@lukesneeringer
Copy link
Contributor

Just sent up a PR for Vision. Will do the rest once my Artman changes are merged.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Apr 17, 2017 •
edited
Loading

Just merged a new GAPIC for Vision, which @stephenplusplus is about to release.
Dropping to P1, but will regenerate all GAPICs soon (after Artman changes are merged).

@lukesneeringer lukesneeringer added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. status: release blocking type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 17, 2017
@stephenplusplus
Copy link
Contributor

Released [email protected] with the change.

@landrito landrito added the api: vision Issues related to the Cloud Vision API. label Apr 17, 2017
@landrito landrito mentioned this issue Apr 17, 2017
Merged
@landrito
Copy link
Contributor

@stephenplusplus #2228 needs to be released to add the 'gccl' header too!

@lukesneeringer
Copy link
Contributor

Sorry, that was my fault; I did not grok that the gccl was not there, and I should have.

@stephenplusplus
Copy link
Contributor

[email protected] published with those.

@stephenplusplus
Copy link
Contributor

@bjwatson @lukesneeringer @landrito is this resolved?

@lukesneeringer
Copy link
Contributor

I believe so.

@lukesneeringer lukesneeringer removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
api: vision Issues related to the Cloud Vision API. core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukesneeringer @bjwatson @stephenplusplus @landrito